Checkstyle for System.out.println or Exception::printStackTrace() #3991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… used. Removed usage of those two in our main code and tests. Signed-off-by: David Venable <[email protected]>
dlvenable
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
asifsmohammed and
oeyh
as code owners
dlvenable
commented
Jan 19, 2024
| @@ -571,15 +574,15 @@ private List<Map<String, Object>> createParquetRecordsList(final InputStream inp | |||
| try { | |||
| eventData.put(field.getName(), simpleGroup.getValueToString(fieldIndex, 0)); | |||
| } catch (Exception parquetException) { | |||
| parquetException.printStackTrace(); | |||
| LOG.error("Failed to parse Parquet", parquetException); | |||
There was a problem hiding this comment.
These exceptions are being thrown, so for now I'm logging the error.
There was a problem hiding this comment.
I created #3992 to track this possible bug.
kkondaka
approved these changes
Jan 23, 2024
graytaylor0
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds two new Checkstyle checks:
System.out.println.printStackTrace()This includes an exception for the
stdoutsink which must callSystem.out.println.There were several occurrence of both and this PR includes checks for these.
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.