[BUG] ParquetOutputCodecTest may not be testing correctly #3992
Labels
bug
Something isn't working
maintenance
Issues to help maintain the project, such as improving builds, testing, etc.
Describe the bug
I removed some try-catch lines in the
ParquetOutputCodecTest
test. These tests began to fail.Something is definitely wrong as the lines in question are part of the setup. It may be that the tests are not actually testing what they claim to test.
To Reproduce
Remove these lines:
data-prepper/data-prepper-plugins/s3-sink/src/test/java/org/opensearch/dataprepper/plugins/codec/parquet/ParquetOutputCodecTest.java
Lines 576 to 578 in c4acf28
data-prepper/data-prepper-plugins/s3-sink/src/test/java/org/opensearch/dataprepper/plugins/codec/parquet/ParquetOutputCodecTest.java
Lines 584 to 585 in c4acf28
Run the tests.
Quite a few of them fail.
Expected behavior
I should be able to run tests without this code throwing exceptions at all.
Additional context
This was found while removing
ex.printStackTrace()
lines:https://github.com/opensearch-project/data-prepper/pull/3991/files#r1459559030
The text was updated successfully, but these errors were encountered: