Added path support for HTTP source #2277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Asif Sohail Mohammed <[email protected]> Signed-off-by: Asif Sohail Mohammed <[email protected]>
dlvenable
requested changes
Feb 14, 2023
| // TODO: allow customization on URI path for log ingestion | ||
| sb.decorator(HTTPSourceConfig.DEFAULT_LOG_INGEST_URI, ThrottlingService.newDecorator(logThrottlingStrategy, logThrottlingRejectHandler)); | ||
|
|
||
| final String httpSourcePath = sourceConfig.getPath().replace("${PIPELINE_NAME}", pipelineName); |
There was a problem hiding this comment.
Let's use ${pipelineName} to match with other parameter naming conventions.
| @@ -22,6 +22,7 @@ source: | |||
| ## Configurations | |||
|
|
|||
| * port (Optional) => An `int` between 0 and 65535 represents the port source is running on. Default is ```2021```. | |||
| * path (Optional) => A `string` which represents the URI path for log ingestion, and it should start with `/`. Path can contain `${PIPELINE_NAME}` placeholder which will be replaced with pipeline name. Default value is `/log/ingest`. | |||
There was a problem hiding this comment.
Please use ${pipelineName} instead of ${PIPELINE_NAME}.
Signed-off-by: Asif Sohail Mohammed <[email protected]> Signed-off-by: Asif Sohail Mohammed <[email protected]>
asifsmohammed
force-pushed
the
http-source-path
branch
from
66f3cfb to
fe23191
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #2277 +/- ##
============================================
- Coverage 93.81% 93.61% -0.20%
- Complexity 1828 1924 +96
============================================
Files 225 225
Lines 5300 5391 +91
Branches 426 427 +1
============================================
+ Hits 4972 5047 +75
- Misses 223 240 +17
+ Partials 105 104 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
dlvenable
approved these changes
Feb 15, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 27, 2023
* Added path support for HTTP source Signed-off-by: Asif Sohail Mohammed <[email protected]> (cherry picked from commit e291070)
asifsmohammed
added a commit
that referenced
this pull request
Feb 28, 2023
* Added path support for HTTP source Signed-off-by: Asif Sohail Mohammed <[email protected]> (cherry picked from commit e291070) Co-authored-by: Asif Sohail Mohammed <[email protected]>
mahesh724
pushed a commit
to mahesh724/data-prepper
that referenced
this pull request
Mar 3, 2023
* Added path support for HTTP source Signed-off-by: Asif Sohail Mohammed <[email protected]> Signed-off-by: mahesh724 <[email protected]>
mahesh724
pushed a commit
to mahesh724/data-prepper
that referenced
this pull request
Mar 9, 2023
* Added path support for HTTP source Signed-off-by: Asif Sohail Mohammed <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pathoption to HTTP sourceIssues Resolved
Resolves #2258
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.