Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the path for HTTP source #2258

Closed
dlvenable opened this issue Feb 9, 2023 · 1 comment · Fixed by #2277
Closed

Change the path for HTTP source #2258

dlvenable opened this issue Feb 9, 2023 · 1 comment · Fixed by #2277
Labels
enhancement New feature or request plugin - source A plugin to receive data from a service or location.
Milestone

Comments

@dlvenable
Copy link
Member

Is your feature request related to a problem? Please describe.

The http source always uses the path log/ingest.

Describe the solution you'd like

Provide a configure to allow a pipeline author to change this path.

source:
  http:
    path: my/unique/path
    ssl: true
    ssl_certificate_file: "/full/path/to/certfile.crt"
    ssl_key_file: "/full/path/to/keyfile.key"

With that configuration, the HTTP source will be available at:

https://localhost:2021/my/unique/path

Describe alternatives you've considered (Optional)

This could use prefix, but I don't see a reason to require the log/ingest. Unlike OTel, this is not a convention.

Additional context

This is somewhat similar to #2257, but this is for the http source only. It is quite different from the OTel sources.

@dlvenable dlvenable added enhancement New feature or request plugin - source A plugin to receive data from a service or location. labels Feb 9, 2023
@asifsmohammed asifsmohammed moved this from Untriaged to To do in Data Prepper Tracking Board Feb 9, 2023
@dlvenable dlvenable added this to the v2.1 milestone Feb 13, 2023
@dlvenable
Copy link
Member Author

Also include a ${pipelineName} variable to allow using the pipelineName as part of the path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request plugin - source A plugin to receive data from a service or location.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant