Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make checkpoint mandatory, add watermark delay, minor UI fixes #173

Merged
merged 8 commits into from
Oct 24, 2023
Merged

Make checkpoint mandatory, add watermark delay, minor UI fixes #173

merged 8 commits into from
Oct 24, 2023

Conversation

ps48
Copy link
Member

@ps48 ps48 commented Oct 24, 2023 •
edited
Loading

Description

Make checkpoint mandatory, add watermark delay, minor UI fixes

Issues Resolved

  1. Makes checkpoint mandatory
  2. Add watermark delay option for materialized view
  3. Minor UI fixes
  4. Update Acc index flyout for mv support
  5. Add test for acc index flyout

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

ps48 added 6 commits October 23, 2023 22:18
@ps48
make checkpoint mandatory
45a4c2f 
Signed-off-by: Shenoy Pratik <[email protected]>
@ps48
update timestamp type for MV
6fc946b 
Signed-off-by: Shenoy Pratik <[email protected]>
@ps48
add watermark and datasource empty check
5890cf5 
Signed-off-by: Shenoy Pratik <[email protected]>
@ps48
minor fixes
1a6136e 
Signed-off-by: Shenoy Pratik <[email protected]>
@ps48
updates datasources acc
4c24c9e 
Signed-off-by: Shenoy Pratik <[email protected]>
@ps48
adding tests for watermark, minor fixes
745cceb 
Signed-off-by: Shenoy Pratik <[email protected]>
@ps48 ps48 marked this pull request as draft October 24, 2023 14:36
@ps48
update acc index flyout
c67c7f0 
Signed-off-by: Shenoy Pratik <[email protected]>
@ps48 ps48 marked this pull request as ready for review October 24, 2023 21:31
@codecov
Copy link

codecov bot commented Oct 24, 2023 •
edited
Loading

Codecov Report

Merging #173 (364585a) into main (dcff236) will increase coverage by 0.47%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #173      +/-   ##
==========================================
+ Coverage   57.92%   58.39%   +0.47%     
==========================================
  Files          32       32              
  Lines        1452     1507      +55     
  Branches      245      260      +15     
==========================================
+ Hits          841      880      +39     
- Misses        591      605      +14     
- Partials       20       22       +2
Flag Coverage Δ
dashboards-query-workbench 58.39% <ø> (+0.47%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 10 files with indirect coverage changes

@ps48
update docs links
364585a 
Signed-off-by: Shenoy Pratik <[email protected]>
@ps48 ps48 merged commit a5aa2d2 into opensearch-project:main Oct 24, 2023
9 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 24, 2023
@github-actions
Make checkpoint mandatory, add watermark delay, minor UI fixes (#173)
84f3469 
* make checkpoint mandatory

Signed-off-by: Shenoy Pratik <[email protected]>

* update timestamp type for MV

Signed-off-by: Shenoy Pratik <[email protected]>

* add watermark and datasource empty check

Signed-off-by: Shenoy Pratik <[email protected]>

* minor fixes

Signed-off-by: Shenoy Pratik <[email protected]>

* updates datasources acc

Signed-off-by: Shenoy Pratik <[email protected]>

* adding tests for watermark, minor fixes

Signed-off-by: Shenoy Pratik <[email protected]>

* update acc index flyout

Signed-off-by: Shenoy Pratik <[email protected]>

* update docs links

Signed-off-by: Shenoy Pratik <[email protected]>

---------

Signed-off-by: Shenoy Pratik <[email protected]>
(cherry picked from commit a5aa2d2)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 24, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 24, 2023
@github-actions
Make checkpoint mandatory, add watermark delay, minor UI fixes (#173)
9d3b7e7 
* make checkpoint mandatory

Signed-off-by: Shenoy Pratik <[email protected]>

* update timestamp type for MV

Signed-off-by: Shenoy Pratik <[email protected]>

* add watermark and datasource empty check

Signed-off-by: Shenoy Pratik <[email protected]>

* minor fixes

Signed-off-by: Shenoy Pratik <[email protected]>

* updates datasources acc

Signed-off-by: Shenoy Pratik <[email protected]>

* adding tests for watermark, minor fixes

Signed-off-by: Shenoy Pratik <[email protected]>

* update acc index flyout

Signed-off-by: Shenoy Pratik <[email protected]>

* update docs links

Signed-off-by: Shenoy Pratik <[email protected]>

---------

Signed-off-by: Shenoy Pratik <[email protected]>
(cherry picked from commit a5aa2d2)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 24, 2023
Merged
ps48 pushed a commit that referenced this pull request Oct 24, 2023
@opensearch-trigger-bot @github-actions
Make checkpoint mandatory, add watermark delay, minor UI fixes (#173) (…
0198fa7 
…#175)

* make checkpoint mandatory



* update timestamp type for MV



* add watermark and datasource empty check



* minor fixes



* updates datasources acc



* adding tests for watermark, minor fixes



* update acc index flyout



* update docs links



---------


(cherry picked from commit a5aa2d2)

Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48 pushed a commit that referenced this pull request Oct 24, 2023
@opensearch-trigger-bot @github-actions
Make checkpoint mandatory, add watermark delay, minor UI fixes (#173) (…
77470e4 
…#174)

* make checkpoint mandatory



* update timestamp type for MV



* add watermark and datasource empty check



* minor fixes



* updates datasources acc



* adding tests for watermark, minor fixes



* update acc index flyout



* update docs links



---------


(cherry picked from commit a5aa2d2)

Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mengweieric added a commit to mengweieric/dashboards-query-workbench that referenced this pull request Nov 8, 2023
@mengweieric
Revert "Make checkpoint mandatory, add watermark delay, minor UI fixes (
ac0de03 
opensearch-project#173) (opensearch-project#175)"

This reverts commit 0198fa7.
mengweieric added a commit to mengweieric/dashboards-query-workbench that referenced this pull request Nov 8, 2023
@mengweieric
Revert "Make checkpoint mandatory, add watermark delay, minor UI fixes (
91e0041 
opensearch-project#173) (opensearch-project#175)"

This reverts commit 0198fa7.

Signed-off-by: Eric <[email protected]>
mengweieric added a commit that referenced this pull request Nov 13, 2023
@mengweieric
Revert commits back to after 2.11 release (#211)
32a7495 
* Revert "Fix error handling for user w/o proper permissions (#195) (#197)"

This reverts commit 26ed0dc.

Signed-off-by: Eric <[email protected]>

* Revert "Increment version to 2.11.1.0 (#186)"

This reverts commit b18f5f4.

Signed-off-by: Eric <[email protected]>

* Revert "added fix for loading spinner issue for other database (#189) (#192)"

This reverts commit 94805c5.

Signed-off-by: Eric <[email protected]>

* Revert "UI-bug fixes, added create query for MV (#182) (#188)"

This reverts commit 4187b6d.

Signed-off-by: Eric <[email protected]>

* Revert "Add backticks and remove ckpt for manual refresh in acceleration flyout (#183) (#185)"

This reverts commit f96c5d9.

Signed-off-by: Eric <[email protected]>

* Revert "Session update, minor fixes for acceleration flyout (#179) (#181)"

This reverts commit 257fb53.

Signed-off-by: Eric <[email protected]>

* Revert "UI fixes for loading state, empty tree, added toast for error, fixed no indicies error (#176) (#178)"

This reverts commit 3c47d47.

Signed-off-by: Eric <[email protected]>

* Revert "Make checkpoint mandatory, add watermark delay, minor UI fixes (#173) (#175)"

This reverts commit 0198fa7.

Signed-off-by: Eric <[email protected]>

* Revert "design changes for loading, changed the banner, updated tests (#170) (#172)"

This reverts commit 786c7c7.

Signed-off-by: Eric <[email protected]>

* Revert "Support dark mode and session for sql, minor bug fixes (#165) (#169)"

This reverts commit 0f5673a.

Signed-off-by: Eric <[email protected]>

* Revert "Added changes for making tree view persistent, made changes for bugs for loading screen (#153) (#167)"

This reverts commit 2269d1d.

Signed-off-by: Eric <[email protected]>

* Revert "fixed create table async query bug (#158) (#163)"

This reverts commit 1964008.

Signed-off-by: Eric <[email protected]>

---------

Signed-off-by: Eric <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmmusings vmmusings vmmusings approved these changes

@kavithacm kavithacm kavithacm approved these changes

@pjfitzgibbons pjfitzgibbons Awaiting requested review from pjfitzgibbons

@derek-ho derek-ho Awaiting requested review from derek-ho derek-ho is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@dai-chen dai-chen Awaiting requested review from dai-chen dai-chen is a code owner

@YANG-DB YANG-DB Awaiting requested review from YANG-DB YANG-DB is a code owner

@rupal-bq rupal-bq Awaiting requested review from rupal-bq

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@Swiddis Swiddis Awaiting requested review from Swiddis Swiddis is a code owner

@penghuo penghuo Awaiting requested review from penghuo penghuo is a code owner

@seankao-az seankao-az Awaiting requested review from seankao-az seankao-az is a code owner

@MaxKsyunz MaxKsyunz Awaiting requested review from MaxKsyunz

@Yury-Fridlyand Yury-Fridlyand Awaiting requested review from Yury-Fridlyand Yury-Fridlyand is a code owner

@anirudha anirudha Awaiting requested review from anirudha anirudha is a code owner

Assignees
No one assigned
Labels
backport 2.x backport 2.11
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ps48 @kavithacm @vmmusings