-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added changes for making tree view persistent, made changes for bugs for loading screen #153
Conversation
Signed-off-by: sumukhswamy <[email protected]>
Signed-off-by: sumukhswamy <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #153 +/- ##
==========================================
+ Coverage 54.65% 59.02% +4.36%
==========================================
Files 33 33
Lines 1396 1452 +56
Branches 224 237 +13
==========================================
+ Hits 763 857 +94
- Misses 548 575 +27
+ Partials 85 20 -65
Flags with carried forward coverage won't be shown. Click here to find out more. |
@sumukhswamy code looks much cleaner now. Added some minor comments, can you please add jest tests for this file? |
Signed-off-by: sumukhswamy <[email protected]>
… loading state Signed-off-by: sumukhswamy <[email protected]>
Signed-off-by: sumukhswamy <[email protected]>
@@ -4,6 +4,7 @@ | |||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please change the filename to https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/DEVELOPER_GUIDE.md#filenames. We added this file in 2.11 hence it should adhere to the OSD plugin guidelines.
Signed-off-by: sumukhswamy <[email protected]>
part1.1.1.mp4 |
Signed-off-by: sumukhswamy <[email protected]>
Signed-off-by: sumukhswamy <[email protected]>
export type AsyncQueryLoadingStatus = 'SUCCESS' | 'FAILED' | 'RUNNING' | 'SCHEDULED' | 'CANCELLED'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want to consider using enum here? something like
export enum AsyncQueryLoadingStatus {
SUCCESS = 'SUCCESS',
FAILED = 'FAILED',
RUNNING = 'RUNNING',
SCHEDULED = 'SCHEDULED',
CANCELLED = 'CANCELLED'
}
export enum TreeItemType {
COVERING_INDEX = 'covering_index',
SKIPPING_INDEX = 'skipping_index',
TABLE = 'table',
DATABASE = 'database',
MATERIALIZED_VIEW = 'materialized_view',
LOAD_MATERIALIZED_VIEW = 'Load Materialized View', // Consider renaming this for consistency
BADGE = 'badge'
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sumukhswamy Can you take this as a fast follow in the next PR?
…for loading screen (#153) * made the tree persistant, added changes for loading screen Signed-off-by: sumukhswamy <[email protected]> * changes for the text displayed during loading screen Signed-off-by: sumukhswamy <[email protected]> * addressed pr comments Signed-off-by: sumukhswamy <[email protected]> * addressed pr comments, added code for reload button Signed-off-by: sumukhswamy <[email protected]> * addressed pr comments, added Materialiazed view badges, bug fixes for loading state Signed-off-by: sumukhswamy <[email protected]> * updated snapshots Signed-off-by: sumukhswamy <[email protected]> * added tests, addressed pr comments Signed-off-by: sumukhswamy <[email protected]> * added fix for text overflowing Signed-off-by: sumukhswamy <[email protected]> --------- Signed-off-by: sumukhswamy <[email protected]> (cherry picked from commit 75f9cca) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…for loading screen (#153) * made the tree persistant, added changes for loading screen Signed-off-by: sumukhswamy <[email protected]> * changes for the text displayed during loading screen Signed-off-by: sumukhswamy <[email protected]> * addressed pr comments Signed-off-by: sumukhswamy <[email protected]> * addressed pr comments, added code for reload button Signed-off-by: sumukhswamy <[email protected]> * addressed pr comments, added Materialiazed view badges, bug fixes for loading state Signed-off-by: sumukhswamy <[email protected]> * updated snapshots Signed-off-by: sumukhswamy <[email protected]> * added tests, addressed pr comments Signed-off-by: sumukhswamy <[email protected]> * added fix for text overflowing Signed-off-by: sumukhswamy <[email protected]> --------- Signed-off-by: sumukhswamy <[email protected]> (cherry picked from commit 75f9cca) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…for loading screen (#153) (#167) * made the tree persistant, added changes for loading screen * changes for the text displayed during loading screen * addressed pr comments * addressed pr comments, added code for reload button * addressed pr comments, added Materialiazed view badges, bug fixes for loading state * updated snapshots * added tests, addressed pr comments * added fix for text overflowing --------- (cherry picked from commit 75f9cca) Signed-off-by: sumukhswamy <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…for loading screen (#153) (#166) * made the tree persistant, added changes for loading screen * changes for the text displayed during loading screen * addressed pr comments * addressed pr comments, added code for reload button * addressed pr comments, added Materialiazed view badges, bug fixes for loading state * updated snapshots * added tests, addressed pr comments * added fix for text overflowing --------- (cherry picked from commit 75f9cca) Signed-off-by: sumukhswamy <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…or bugs for loading screen (opensearch-project#153) (opensearch-project#167)" This reverts commit 2269d1d.
…or bugs for loading screen (opensearch-project#153) (opensearch-project#167)" This reverts commit 2269d1d. Signed-off-by: Eric <[email protected]>
* Revert "Fix error handling for user w/o proper permissions (#195) (#197)" This reverts commit 26ed0dc. Signed-off-by: Eric <[email protected]> * Revert "Increment version to 2.11.1.0 (#186)" This reverts commit b18f5f4. Signed-off-by: Eric <[email protected]> * Revert "added fix for loading spinner issue for other database (#189) (#192)" This reverts commit 94805c5. Signed-off-by: Eric <[email protected]> * Revert "UI-bug fixes, added create query for MV (#182) (#188)" This reverts commit 4187b6d. Signed-off-by: Eric <[email protected]> * Revert "Add backticks and remove ckpt for manual refresh in acceleration flyout (#183) (#185)" This reverts commit f96c5d9. Signed-off-by: Eric <[email protected]> * Revert "Session update, minor fixes for acceleration flyout (#179) (#181)" This reverts commit 257fb53. Signed-off-by: Eric <[email protected]> * Revert "UI fixes for loading state, empty tree, added toast for error, fixed no indicies error (#176) (#178)" This reverts commit 3c47d47. Signed-off-by: Eric <[email protected]> * Revert "Make checkpoint mandatory, add watermark delay, minor UI fixes (#173) (#175)" This reverts commit 0198fa7. Signed-off-by: Eric <[email protected]> * Revert "design changes for loading, changed the banner, updated tests (#170) (#172)" This reverts commit 786c7c7. Signed-off-by: Eric <[email protected]> * Revert "Support dark mode and session for sql, minor bug fixes (#165) (#169)" This reverts commit 0f5673a. Signed-off-by: Eric <[email protected]> * Revert "Added changes for making tree view persistent, made changes for bugs for loading screen (#153) (#167)" This reverts commit 2269d1d. Signed-off-by: Eric <[email protected]> * Revert "fixed create table async query bug (#158) (#163)" This reverts commit 1964008. Signed-off-by: Eric <[email protected]> --------- Signed-off-by: Eric <[email protected]>
Description
Treeview updates
loading screen updates
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.