added changes for moving notebooks to .kibana #1937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumukhswamy
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az,
anirudha and
paulstn
as code owners
sumukhswamy
commented
Jul 10, 2024
joshuali925
reviewed
Jul 11, 2024
sumukhswamy
force-pushed
the
move-notebooks
branch
3 times, most recently
from
2f781d9 to
e95d3a9
Compare
joshuali925
reviewed
Jul 17, 2024
|
@sumukhswamy can you share testing screenshot or videos? |
sumukhswamy
force-pushed
the
move-notebooks
branch
from
ec47c3f to
3908fa1
Compare
ps48
reviewed
Jul 19, 2024
ps48
reviewed
Jul 19, 2024
ps48
reviewed
Jul 19, 2024
Screen.Recording.2024-07-19.at.5.30.36.PM.mov |
Signed-off-by: sumukhswamy <[email protected]>
Signed-off-by: sumukhswamy <[email protected]>
Signed-off-by: sumukhswamy <[email protected]>
Signed-off-by: sumukhswamy <[email protected]>
Signed-off-by: sumukhswamy <[email protected]>
Signed-off-by: sumukhswamy <[email protected]>
Signed-off-by: sumukhswamy <[email protected]>
Signed-off-by: sumukhswamy <[email protected]>
Signed-off-by: sumukhswamy <[email protected]>
Signed-off-by: sumukhswamy <[email protected]>
Signed-off-by: sumukhswamy <[email protected]>
sumukhswamy
force-pushed
the
move-notebooks
branch
from
ee724a2 to
ec8ee32
Compare
Signed-off-by: sumukhswamy <[email protected]>
Signed-off-by: sumukhswamy <[email protected]>
Signed-off-by: sumukhswamy <[email protected]>
ps48
approved these changes
Jul 22, 2024
|
@sumukhswamy I see the snapshots still failing are you using the latest main branch from core dashboards? |
Signed-off-by: sumukhswamy <[email protected]>
joshuali925
approved these changes
Jul 22, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 22, 2024
* added changes for moving notebooks to .kibana Signed-off-by: sumukhswamy <[email protected]> * updated tests Signed-off-by: sumukhswamy <[email protected]> * added changes for older notebooks viewing Signed-off-by: sumukhswamy <[email protected]> * mds changes for notebooks -s Signed-off-by: sumukhswamy <[email protected]> * resolved conflicts Signed-off-by: sumukhswamy <[email protected]> * linter fixes Signed-off-by: sumukhswamy <[email protected]> * added changes for mds, persistance and sample notebooks Signed-off-by: sumukhswamy <[email protected]> * changed route to /savednotebook Signed-off-by: sumukhswamy <[email protected]> * addressed comments Signed-off-by: sumukhswamy <[email protected]> * edge cases for migration Signed-off-by: sumukhswamy <[email protected]> * adeed unit tests Signed-off-by: sumukhswamy <[email protected]> * updated snapshots Signed-off-by: sumukhswamy <[email protected]> * updated snapshots Signed-off-by: sumukhswamy <[email protected]> * added changes for cypress tests Signed-off-by: sumukhswamy <[email protected]> * changed cypress test as rename and duplicate has been removed Signed-off-by: sumukhswamy <[email protected]> --------- Signed-off-by: sumukhswamy <[email protected]> (cherry picked from commit 2ab8369) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sumukhswamy
pushed a commit
that referenced
this pull request
Jul 22, 2024
* added changes for moving notebooks to .kibana * updated tests * added changes for older notebooks viewing * mds changes for notebooks -s * resolved conflicts * linter fixes * added changes for mds, persistance and sample notebooks * changed route to /savednotebook * addressed comments * edge cases for migration * adeed unit tests * updated snapshots * updated snapshots * added changes for cypress tests * changed cypress test as rename and duplicate has been removed --------- (cherry picked from commit 2ab8369) Signed-off-by: sumukhswamy <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 22, 2024
* added changes for moving notebooks to .kibana Signed-off-by: sumukhswamy <[email protected]> * updated tests Signed-off-by: sumukhswamy <[email protected]> * added changes for older notebooks viewing Signed-off-by: sumukhswamy <[email protected]> * mds changes for notebooks -s Signed-off-by: sumukhswamy <[email protected]> * resolved conflicts Signed-off-by: sumukhswamy <[email protected]> * linter fixes Signed-off-by: sumukhswamy <[email protected]> * added changes for mds, persistance and sample notebooks Signed-off-by: sumukhswamy <[email protected]> * changed route to /savednotebook Signed-off-by: sumukhswamy <[email protected]> * addressed comments Signed-off-by: sumukhswamy <[email protected]> * edge cases for migration Signed-off-by: sumukhswamy <[email protected]> * adeed unit tests Signed-off-by: sumukhswamy <[email protected]> * updated snapshots Signed-off-by: sumukhswamy <[email protected]> * updated snapshots Signed-off-by: sumukhswamy <[email protected]> * added changes for cypress tests Signed-off-by: sumukhswamy <[email protected]> * changed cypress test as rename and duplicate has been removed Signed-off-by: sumukhswamy <[email protected]> --------- Signed-off-by: sumukhswamy <[email protected]> (cherry picked from commit 2ab8369) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48
pushed a commit
that referenced
this pull request
Jul 22, 2024
* added changes for moving notebooks to .kibana * updated tests * added changes for older notebooks viewing * mds changes for notebooks -s * resolved conflicts * linter fixes * added changes for mds, persistance and sample notebooks * changed route to /savednotebook * addressed comments * edge cases for migration * adeed unit tests * updated snapshots * updated snapshots * added changes for cypress tests * changed cypress test as rename and duplicate has been removed --------- (cherry picked from commit 2ab8369) Signed-off-by: sumukhswamy <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.