added changes for moving notebooks to .kibana (#1937)

* added changes for moving notebooks to .kibana Signed-off-by: sumukhswamy <[email protected]> * updated tests Signed-off-by: sumukhswamy <[email protected]> * added changes for older notebooks viewing Signed-off-by: sumukhswamy <[email protected]> * mds changes for notebooks -s Signed-off-by: sumukhswamy <[email protected]> * resolved conflicts Signed-off-by: sumukhswamy <[email protected]> * linter fixes Signed-off-by: sumukhswamy <[email protected]> * added changes for mds, persistance and sample notebooks Signed-off-by: sumukhswamy <[email protected]> * changed route to /savednotebook Signed-off-by: sumukhswamy <[email protected]> * addressed comments Signed-off-by: sumukhswamy <[email protected]> * edge cases for migration Signed-off-by: sumukhswamy <[email protected]> * adeed unit tests Signed-off-by: sumukhswamy <[email protected]> * updated snapshots Signed-off-by: sumukhswamy <[email protected]> * updated snapshots Signed-off-by: sumukhswamy <[email protected]> * added changes for cypress tests Signed-off-by: sumukhswamy <[email protected]> * changed cypress test as rename and duplicate has been removed Signed-off-by: sumukhswamy <[email protected]> --------- Signed-off-by: sumukhswamy <[email protected]> (cherry picked from commit 2ab8369) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-project · Jul 22, 2024 · 9f7f45a · 9f7f45a
1 parent cd02824
commit 9f7f45a
Show file tree

Hide file tree

Showing 33 changed files with 1,751 additions and 1,068 deletions.
diff --git a/.cypress/integration/notebooks_test/notebooks.spec.js b/.cypress/integration/notebooks_test/notebooks.spec.js
@@ -93,33 +93,16 @@ describe('Testing notebooks table', () => {
     cy.contains(TEST_NOTEBOOK).should('exist');
   });
 
-  it('Duplicates a notebook', () => {
-    cy.get('.euiCheckbox__input[title="Select this row"]').eq(0).click();
-    cy.get('button[data-test-subj="notebookTableActionBtn"]').click();
-    cy.get('button[data-test-subj="duplicateNotebookBtn"]').click();
-    cy.get('button[data-test-subj="custom-input-modal-confirm-button"]').click();
-
-    cy.get('.euiCheckbox__input[title="Select this row"]').eq(1).click();
-  });
-
-  it('Renames a notebook', () => {
-    cy.get('.euiCheckbox__input[title="Select this row"]').eq(0).click();
-    cy.get('button[data-test-subj="notebookTableActionBtn"]').click();
-    cy.get('button[data-test-subj="renameNotebookBtn"]').click();
-    cy.get('input[data-test-subj="custom-input-modal-input"]').focus().type(' (rename)');
-    cy.get('button[data-test-subj="custom-input-modal-confirm-button"]').click();
-  });
-
   it('Searches existing notebooks', () => {
     cy.get('input.euiFieldSearch').focus().type('this notebook should not exist');
     cy.get('.euiTableCellContent__text').contains('No items found').should('exist');
     cy.get('.euiFormControlLayoutClearButton').click();
     cy.get('input.euiFieldSearch')
       .focus()
-      .type(TEST_NOTEBOOK + ' (copy) (rename)');
+      .type(TEST_NOTEBOOK);
 
     cy.get('a.euiLink')
-      .contains(TEST_NOTEBOOK + ' (copy) (rename)')
+      .contains(TEST_NOTEBOOK)
       .should('exist');
   });
 

diff --git a/common/types/notebooks.ts b/common/types/notebooks.ts
@@ -4,16 +4,14 @@
  */
 
 import { RefObject } from 'react';
-import { DashboardStart } from "../../../../src/plugins/dashboard/public";
-import { NavigationPublicPluginStart } from "../../../../src/plugins/navigation/public";
 
 export interface NotebooksPluginSetup {
   getGreeting: () => string;
 }
 // eslint-disable-next-line @typescript-eslint/no-empty-interface
 export interface NotebooksPluginStart {}
 
-export interface optionsType {
+export interface OptionsType {
   baseUrl: string;
   payload?: any;
   headers?: any;
@@ -27,7 +25,7 @@ export interface optionsType {
   ciphers?: string; // The TLS ciphers to support
 }
 
-export type ParaType = {
+export interface ParaType {
   uniqueId: string;
   isRunning: boolean;
   inQueue: boolean;
@@ -41,7 +39,7 @@ export type ParaType = {
   inp: string;
   lang: string;
   editorLanguage: string;
-  typeOut: Array<string>;
+  typeOut: string[];
   out: any[];
   isInputExpanded: boolean;
   isOutputStale: boolean;
@@ -50,4 +48,6 @@ export type ParaType = {
   visStartTime?: string;
   visEndTime?: string;
   visSavedObjId?: string;
-};
+  dataSourceMDSId?: string;
+  dataSourceMDSLabel?: string;
+}
diff --git a/common/types/observability_saved_object_attributes.ts b/common/types/observability_saved_object_attributes.ts
@@ -8,9 +8,11 @@ import { SavedQuery, SavedVisualization } from './explorer';
 
 export const VISUALIZATION_SAVED_OBJECT = 'observability-visualization';
 export const SEARCH_SAVED_OBJECT = 'observability-search';
+export const NOTEBOOK_SAVED_OBJECT = 'observability-notebook';
 export const OBSERVABILTY_SAVED_OBJECTS = [
   VISUALIZATION_SAVED_OBJECT,
   SEARCH_SAVED_OBJECT,
+  NOTEBOOK_SAVED_OBJECT,
 ] as const;
 export const SAVED_OBJECT_VERSION = 1;
 

diff --git a/public/components/custom_panels/__tests__/__snapshots__/custom_panel_view.test.tsx.snap b/public/components/custom_panels/__tests__/__snapshots__/custom_panel_view.test.tsx.snap
@@ -303,7 +303,7 @@ exports[`Panels View Component render panel view container and refresh panel 1`]
                   class="euiToolTipAnchor"
                 >
                   <button
-                    class="euiButton euiButton--primary euiButton--fill euiSuperUpdateButton"
+                    class="euiButton euiButton--primary euiSuperUpdateButton"
                     data-test-subj="superDatePickerApplyTimeButton"
                     type="button"
                   >
@@ -734,7 +734,7 @@ exports[`Panels View Component render panel view so container and reload dashboa
                   class="euiToolTipAnchor"
                 >
                   <button
-                    class="euiButton euiButton--primary euiButton--fill euiSuperUpdateButton"
+                    class="euiButton euiButton--primary euiSuperUpdateButton"
                     data-test-subj="superDatePickerApplyTimeButton"
                     type="button"
                   >
@@ -2334,7 +2334,6 @@ exports[`Panels View Component renders panel view container with visualizations
                                             className="euiSuperUpdateButton"
                                             color="primary"
                                             data-test-subj="superDatePickerApplyTimeButton"
-                                            fill={true}
                                             iconType="refresh"
                                             isDisabled={false}
                                             isLoading={false}
@@ -2354,7 +2353,6 @@ exports[`Panels View Component renders panel view container with visualizations
                                               data-test-subj="superDatePickerApplyTimeButton"
                                               disabled={false}
                                               element="button"
-                                              fill={true}
                                               iconType="refresh"
                                               isDisabled={false}
                                               isLoading={false}
@@ -2369,7 +2367,7 @@ exports[`Panels View Component renders panel view container with visualizations
                                               type="button"
                                             >
                                               <button
-                                                className="euiButton euiButton--primary euiButton--fill euiSuperUpdateButton"
+                                                className="euiButton euiButton--primary euiSuperUpdateButton"
                                                 data-test-subj="superDatePickerApplyTimeButton"
                                                 disabled={false}
                                                 onBlur={[Function]}
@@ -4581,7 +4579,6 @@ exports[`Panels View Component renders panel view container without visualizatio
                                             className="euiSuperUpdateButton"
                                             color="primary"
                                             data-test-subj="superDatePickerApplyTimeButton"
-                                            fill={true}
                                             iconType="refresh"
                                             isDisabled={false}
                                             isLoading={false}
@@ -4601,7 +4598,6 @@ exports[`Panels View Component renders panel view container without visualizatio
                                               data-test-subj="superDatePickerApplyTimeButton"
                                               disabled={false}
                                               element="button"
-                                              fill={true}
                                               iconType="refresh"
                                               isDisabled={false}
                                               isLoading={false}
@@ -4616,7 +4612,7 @@ exports[`Panels View Component renders panel view container without visualizatio
                                               type="button"
                                             >
                                               <button
-                                                className="euiButton euiButton--primary euiButton--fill euiSuperUpdateButton"
+                                                className="euiButton euiButton--primary euiSuperUpdateButton"
                                                 data-test-subj="superDatePickerApplyTimeButton"
                                                 disabled={false}
                                                 onBlur={[Function]}

diff --git a/public/components/custom_panels/__tests__/__snapshots__/custom_panel_view_so.test.tsx.snap b/public/components/custom_panels/__tests__/__snapshots__/custom_panel_view_so.test.tsx.snap
@@ -303,7 +303,7 @@ exports[`Panels View SO Component render panel view container and refresh panel
                   class="euiToolTipAnchor"
                 >
                   <button
-                    class="euiButton euiButton--primary euiButton--fill euiSuperUpdateButton"
+                    class="euiButton euiButton--primary euiSuperUpdateButton"
                     data-test-subj="superDatePickerApplyTimeButton"
                     type="button"
                   >
@@ -734,7 +734,7 @@ exports[`Panels View SO Component render panel view so container and reload dash
                   class="euiToolTipAnchor"
                 >
                   <button
-                    class="euiButton euiButton--primary euiButton--fill euiSuperUpdateButton"
+                    class="euiButton euiButton--primary euiSuperUpdateButton"
                     data-test-subj="superDatePickerApplyTimeButton"
                     type="button"
                   >
@@ -1167,7 +1167,7 @@ exports[`Panels View SO Component renders panels view SO container with visualiz
                   class="euiToolTipAnchor"
                 >
                   <button
-                    class="euiButton euiButton--primary euiButton--fill euiSuperUpdateButton"
+                    class="euiButton euiButton--primary euiSuperUpdateButton"
                     data-test-subj="superDatePickerApplyTimeButton"
                     type="button"
                   >

diff --git a/public/components/metrics/top_menu/__tests__/__snapshots__/top_menu.test.tsx.snap b/public/components/metrics/top_menu/__tests__/__snapshots__/top_menu.test.tsx.snap
@@ -697,7 +697,6 @@ exports[`Metrics Top Menu Component renders Top Menu Component when enabled 1`]
                               className="euiSuperUpdateButton"
                               color="primary"
                               data-test-subj="superDatePickerApplyTimeButton"
-                              fill={true}
                               iconType="refresh"
                               isDisabled={false}
                               isLoading={false}
@@ -717,7 +716,6 @@ exports[`Metrics Top Menu Component renders Top Menu Component when enabled 1`]
                                 data-test-subj="superDatePickerApplyTimeButton"
                                 disabled={false}
                                 element="button"
-                                fill={true}
                                 iconType="refresh"
                                 isDisabled={false}
                                 isLoading={false}
@@ -732,7 +730,7 @@ exports[`Metrics Top Menu Component renders Top Menu Component when enabled 1`]
                                 type="button"
                               >
                                 <button
-                                  className="euiButton euiButton--primary euiButton--fill euiSuperUpdateButton"
+                                  className="euiButton euiButton--primary euiSuperUpdateButton"
                                   data-test-subj="superDatePickerApplyTimeButton"
                                   disabled={false}
                                   onBlur={[Function]}