update cloud trail integration with flint-s3 based DDL assets and das… #1701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hboard Signed-off-by: YANGDB <[email protected]>
YANG-DB
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
rupal-bq,
mengweieric,
vamsimanohar,
Swiddis,
penghuo,
seankao-az,
anirudha,
paulstn and
sumukhswamy
as code owners
Signed-off-by: YANGDB <[email protected]>
Signed-off-by: YANGDB <[email protected]>
Signed-off-by: YANGDB <[email protected]>
Signed-off-by: YANGDB <[email protected]>
RyanL1997
approved these changes
Apr 16, 2024
Swiddis
approved these changes
Apr 16, 2024
YANG-DB
added
backport 2.x
integrations
sejli
approved these changes
Apr 16, 2024
| WITH ( | ||
| auto_refresh = true, | ||
| checkpoint_location = '{s3_checkpoint_location}', | ||
| watermark_delay = '1 day', |
There was a problem hiding this comment.
Should we be using 1 day? I believe most, if not all, of our MV definitions are using 1 minute.
seankao-az
reviewed
Apr 16, 2024
| "version": "1.0.0", | ||
| "extension": "sql", | ||
| "type": "query", | ||
| "workflows": ["dashboards-flint"] |
There was a problem hiding this comment.
In other integrations I think create table isn't bounded to any workflow
There was a problem hiding this comment.
it should be since in the future SQL can both be used internally (index query) or externally (flint spark query)
Signed-off-by: YANGDB <[email protected]>
seankao-az
approved these changes
Apr 16, 2024
|
FYI watermark_delay isn't about refresh sync rate: https://github.com/opensearch-project/opensearch-spark/blob/main/docs/index.md#create-index-options |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 16, 2024
#1701) * update cloud trail integration with flint-s3 based DDL assets and dashboard Signed-off-by: YANGDB <[email protected]> * update time field using CAST to TIMESTAMP Signed-off-by: YANGDB <[email protected]> * update separate flint dashboard support and workflow Signed-off-by: YANGDB <[email protected]> * update separate flint dashboard support and workflow Signed-off-by: YANGDB <[email protected]> * update separate flint dashboard support and workflow Signed-off-by: YANGDB <[email protected]> * update refresh sync rate Signed-off-by: YANGDB <[email protected]> --------- Signed-off-by: YANGDB <[email protected]> (cherry picked from commit bccdc31) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
seankao-az
reviewed
Apr 16, 2024
| @@ -0,0 +1,54 @@ | |||
| CREATE MATERIALIZED VIEW {table_name}_mview AS | |||
There was a problem hiding this comment.
__mview instead of _mview
RyanL1997
pushed a commit
to RyanL1997/dashboards-observability
that referenced
this pull request
Apr 18, 2024
…opensearch-project#1701) Signed-off-by: Craig Perkins <[email protected]> Co-authored-by: Darshit Chanpura <[email protected]> (cherry picked from commit 6374198119fcb2b33343460a3d2fdfcb44794f30) Co-authored-by: Craig Perkins <[email protected]>
amsiglan
pushed a commit
to amsiglan/dashboards-observability
that referenced
this pull request
Jun 7, 2024
opensearch-project#1701) * update cloud trail integration with flint-s3 based DDL assets and dashboard Signed-off-by: YANGDB <[email protected]> * update time field using CAST to TIMESTAMP Signed-off-by: YANGDB <[email protected]> * update separate flint dashboard support and workflow Signed-off-by: YANGDB <[email protected]> * update separate flint dashboard support and workflow Signed-off-by: YANGDB <[email protected]> * update separate flint dashboard support and workflow Signed-off-by: YANGDB <[email protected]> * update refresh sync rate Signed-off-by: YANGDB <[email protected]> --------- Signed-off-by: YANGDB <[email protected]> (cherry picked from commit bccdc31)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
update cloud trail integration with flint-s3 based DDL assets and dashboard
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.