[Backport 2.x] [Feature] Acceleration Actions Implementation #1563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Refactor the icon clicks and introduce vacuum to flyout inside icon Signed-off-by: Ryan Liang <[email protected]> * Add vacuum icon for acceleration table Signed-off-by: Ryan Liang <[email protected]> * Add DELETE ui flow for acceleration table only Signed-off-by: Ryan Liang <[email protected]> * Add VACUUM flow to acceleration table only Signed-off-by: Ryan Liang <[email protected]> * Handle skip index naming in overlay Signed-off-by: Ryan Liang <[email protected]> * Refactor the overlay logic a bit in acceleration table class Signed-off-by: Ryan Liang <[email protected]> * Use util function for creating displayIndexName in overlay Signed-off-by: Ryan Liang <[email protected]> * Add delete flow for acceleration table 0 Signed-off-by: Ryan Liang <[email protected]> * Bond refresh logic when delete was successful Signed-off-by: Ryan Liang <[email protected]> * Add vacuum flow for acceleration table Signed-off-by: Ryan Liang <[email protected]> * Rename the class into acceleration operations Signed-off-by: Ryan Liang <[email protected]> * Switch the acc flyout icon into broom Signed-off-by: Ryan Liang <[email protected]> * add vacuum on acc flyout 0 Signed-off-by: Ryan Liang <[email protected]> * Change to closing overlay immediately after clicking confirm Signed-off-by: Ryan Liang <[email protected]> * Add flyout reset and fix the confirm behavior Signed-off-by: Ryan Liang <[email protected]> * add vacuum on acc flyout final Signed-off-by: Ryan Liang <[email protected]> * Add close flyout after the succeed status check Signed-off-by: Ryan Liang <[email protected]> * Add teh refresh in acc flyout and trigger after delete/vacuum Signed-off-by: Ryan Liang <[email protected]> * remove comment Signed-off-by: Ryan Liang <[email protected]> * Mini refactor on load status in operation class Signed-off-by: Ryan Liang <[email protected]> * Fix the mv flow Signed-off-by: Ryan Liang <[email protected]> * Remove the sql definition tab Signed-off-by: Ryan Liang <[email protected]> * Correct the visualization of show refresh interval in flyout Signed-off-by: Ryan Liang <[email protected]> * Update the show time logic with refresh + time zone localization Signed-off-by: Ryan Liang <[email protected]> * Define the behavior of refresh icon in both table and flyout Signed-off-by: Ryan Liang <[email protected]> * Update teh acc table test to fix the build Signed-off-by: Ryan Liang <[email protected]> * Update utils to consume the sync action Signed-off-by: Ryan Liang <[email protected]> * Add sync flow to table behavior but with fail status Signed-off-by: Ryan Liang <[email protected]> * Add sync flow to detail flyout but with fail status Signed-off-by: Ryan Liang <[email protected]> * Add the restriction for only sync active acceleration Signed-off-by: Ryan Liang <[email protected]> * Fix the navigate to datasource link Signed-off-by: Ryan Liang <[email protected]> * Implement the single toast control for each status Signed-off-by: Ryan Liang <[email protected]> * Fix keep pulling after switch rendering Signed-off-by: Ryan Liang <[email protected]> * Fix types Signed-off-by: Ryan Liang <[email protected]> * Remove the sql definition class Signed-off-by: Ryan Liang <[email protected]> * Add basic tests for acceleration overlay Signed-off-by: Ryan Liang <[email protected]> * Add basic tests for acceleration operation Signed-off-by: Ryan Liang <[email protected]> * Remove console log Signed-off-by: Ryan Liang <[email protected]> * Remove refresh icon in utils Signed-off-by: Ryan Liang <[email protected]> * Remove the final status check for sync action Signed-off-by: Ryan Liang <[email protected]> * remove unnecessary check Signed-off-by: Ryan Liang <[email protected]> * remove stable datasource from dependencies array Signed-off-by: Ryan Liang <[email protected]> * Resolve conflicts Signed-off-by: Ryan Liang <[email protected]> * Fix lint Signed-off-by: Ryan Liang <[email protected]> * Fix type in types Signed-off-by: Ryan Liang <[email protected]> * Finalize the name for skipping index Signed-off-by: Ryan Liang <[email protected]> * Refactor testing constants Signed-off-by: Ryan Liang <[email protected]> * Upadate the class prop to remove unused index name Signed-off-by: Ryan Liang <[email protected]> --------- Signed-off-by: Ryan Liang <[email protected]> (cherry picked from commit 376fde4) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az and
anirudha
as code owners
ps48
approved these changes
Mar 18, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #1563 +/- ##
==========================================
- Coverage 58.09% 58.07% -0.02%
==========================================
Files 362 363 +1
Lines 13227 13394 +167
Branches 3445 3494 +49
==========================================
+ Hits 7684 7779 +95
- Misses 5484 5555 +71
- Partials 59 60 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mengweieric
approved these changes
Mar 19, 2024
RyanL1997
pushed a commit
to RyanL1997/dashboards-observability
that referenced
this pull request
Apr 18, 2024
…opensearch-project#1701) Signed-off-by: Craig Perkins <[email protected]> Co-authored-by: Darshit Chanpura <[email protected]> (cherry picked from commit 6374198119fcb2b33343460a3d2fdfcb44794f30) Co-authored-by: Craig Perkins <[email protected]>
amsiglan
pushed a commit
to amsiglan/dashboards-observability
that referenced
this pull request
Jun 7, 2024
… (opensearch-project#1563) * Refactor the icon clicks and introduce vacuum to flyout inside icon * Add vacuum icon for acceleration table * Add DELETE ui flow for acceleration table only * Add VACUUM flow to acceleration table only * Handle skip index naming in overlay * Refactor the overlay logic a bit in acceleration table class * Use util function for creating displayIndexName in overlay * Add delete flow for acceleration table 0 * Bond refresh logic when delete was successful * Add vacuum flow for acceleration table * Rename the class into acceleration operations * Switch the acc flyout icon into broom * add vacuum on acc flyout 0 * Change to closing overlay immediately after clicking confirm * Add flyout reset and fix the confirm behavior * add vacuum on acc flyout final * Add close flyout after the succeed status check * Add teh refresh in acc flyout and trigger after delete/vacuum * remove comment * Mini refactor on load status in operation class * Fix the mv flow * Remove the sql definition tab * Correct the visualization of show refresh interval in flyout * Update the show time logic with refresh + time zone localization * Define the behavior of refresh icon in both table and flyout * Update teh acc table test to fix the build * Update utils to consume the sync action * Add sync flow to table behavior but with fail status * Add sync flow to detail flyout but with fail status * Add the restriction for only sync active acceleration * Fix the navigate to datasource link * Implement the single toast control for each status * Fix keep pulling after switch rendering * Fix types * Remove the sql definition class * Add basic tests for acceleration overlay * Add basic tests for acceleration operation * Remove console log * Remove refresh icon in utils * Remove the final status check for sync action * remove unnecessary check * remove stable datasource from dependencies array * Resolve conflicts * Fix lint * Fix type in types * Finalize the name for skipping index * Refactor testing constants * Upadate the class prop to remove unused index name --------- (cherry picked from commit 376fde4) Signed-off-by: Ryan Liang <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit 668a968)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 376fde4 from #1540.