[Backport 2.x] Allow browsing integrations in Flyout from Data Sources page #1562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Move add integration button to custom component Signed-off-by: Simeon Widdis <[email protected]> * Add flyout toggle in installed integrations table Signed-off-by: Simeon Widdis <[email protected]> * Fix category filters naming Signed-off-by: Simeon Widdis <[email protected]> * Break out integration category filter Signed-off-by: Simeon Widdis <[email protected]> * Repair category filtering for new install flyout Signed-off-by: Simeon Widdis <[email protected]> * Update testing constants for new filter handling Signed-off-by: Simeon Widdis <[email protected]> * Add tests for new flyout Signed-off-by: Simeon Widdis <[email protected]> * Move basePathLink to shared utils Signed-off-by: Simeon Widdis <[email protected]> --------- Signed-off-by: Simeon Widdis <[email protected]> (cherry picked from commit 7d29261) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az and
anirudha
as code owners
|
Interdependent with #1561: Need to merge this before we can backport 1561 (or we get a gnarly merge conflict), but we need to merge both this and 1561's backport before 2.13 is cut (or we get an incomplete feature). |
Swiddis
added
enhancement
Swiddis
approved these changes
Mar 18, 2024
ps48
approved these changes
Mar 18, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #1562 +/- ##
==========================================
+ Coverage 58.09% 58.12% +0.02%
==========================================
Files 362 362
Lines 13227 13260 +33
Branches 3445 3460 +15
==========================================
+ Hits 7684 7707 +23
- Misses 5484 5493 +9
- Partials 59 60 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
amsiglan
pushed a commit
to amsiglan/dashboards-observability
that referenced
this pull request
Jun 7, 2024
…s page (opensearch-project#1562) * Move add integration button to custom component * Add flyout toggle in installed integrations table * Fix category filters naming * Break out integration category filter * Repair category filtering for new install flyout * Update testing constants for new filter handling * Add tests for new flyout * Move basePathLink to shared utils --------- (cherry picked from commit 7d29261) Signed-off-by: Simeon Widdis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit 36bd75e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 7d29261 from #1560.