-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration installation to data sources flyout #1561
Add integration installation to data sources flyout #1561
Conversation
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
@@ -148,9 +149,25 @@ export const InstallIntegrationFlyout = ({ | |||
), | |||
}; | |||
|
|||
const [installingIntegration, setInstallingIntegration] = useState<string | null>(null); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To allow installing in a flyout: We add the optional parameter setInstallingIntegration
that is used to conditionally override the href to the setup page with an onClick that sets installingIntegration
to the selected integration. (See diff in available_integration_table.tsx
.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: if we switch to use navigateToApp()
, do we still need this?
Reference:
Implementation of the EuiLink for datasource:
Line 107 in 31d506a
coreRefs?.application!.navigateToApp(observabilityDataConnectionsID, { |
</EuiBottomBar> | ||
</> | ||
); | ||
} else if (renderType === 'flyout') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bottom bar doesn't render in a flyout if we keep the existing EuiPage component, so I added multiple render types that swap the top-level components between those for an independent page or those for a flyout body. Slightly annoying but not sure what a better way is.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1561 +/- ##
==========================================
- Coverage 57.85% 57.82% -0.03%
==========================================
Files 366 366
Lines 13639 13666 +27
Branches 3555 3573 +18
==========================================
+ Hits 7891 7903 +12
- Misses 5687 5701 +14
- Partials 61 62 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
…ddis/dashboards-observability into feature/ds-install-in-flyout
* Allow rendering install in flyout Signed-off-by: Simeon Widdis <[email protected]> * Activate moving between integration browser and install view Signed-off-by: Simeon Widdis <[email protected]> * Lock flyout install to S3 Signed-off-by: Simeon Widdis <[email protected]> * Autofill and lock data source name in install flyout Signed-off-by: Simeon Widdis <[email protected]> * Update cypress card navigation test Signed-off-by: Simeon Widdis <[email protected]> --------- Signed-off-by: Simeon Widdis <[email protected]> (cherry picked from commit 6f75c96) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-project#1557) (opensearch-project#1561) * Fix bug with nextUrl using SAML and multiauth enabled Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit f655ccf023d4266874d540478f4fb63779cebb09) Co-authored-by: Craig Perkins <[email protected]>
Description
Continuing off #1560, this PR adds the ability to install integrations from the Flyout.
Screen.Recording.2024-03-18.at.4.21.04.PM.mov
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.