Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Backport/backport 1327 to main #1328

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

pjfitzgibbons
Copy link
Contributor

@pjfitzgibbons pjfitzgibbons commented Dec 22, 2023

Description

Backport #1327 to main

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Dec 22, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (30704a0) 51.55% compared to head (0db411b) 51.57%.

Files Patch % Lines
...ks/components/paragraph_components/para_output.tsx 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1328      +/-   ##
==========================================
+ Coverage   51.55%   51.57%   +0.01%     
==========================================
  Files         305      305              
  Lines       10652    10651       -1     
  Branches     2794     2793       -1     
==========================================
+ Hits         5492     5493       +1     
+ Misses       5114     5112       -2     
  Partials       46       46              
Flag Coverage Δ
dashboards-observability 51.57% <75.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Peter Fitzgibbons <[email protected]>
@pjfitzgibbons pjfitzgibbons force-pushed the backport/backport-1327-to-main branch from 780722a to 0db411b Compare December 22, 2023 22:22
@pjfitzgibbons pjfitzgibbons merged commit cdbcfa4 into main Dec 22, 2023
16 of 30 checks passed
@pjfitzgibbons pjfitzgibbons deleted the backport/backport-1327-to-main branch December 22, 2023 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants