Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct date pass-through on Notebook Visualizations. #1327

Merged
merged 3 commits into from
Dec 22, 2023

Conversation

pjfitzgibbons
Copy link
Contributor

Also fix an scss error.

Description

Notebook visualizations date pass-through from Notebook Paragraph is corrected.

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Also fix an scss error.

Signed-off-by: Peter Fitzgibbons <[email protected]>
Copy link

codecov bot commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2c969e3) 51.61% compared to head (27a39a9) 51.61%.

Additional details and impacted files
@@           Coverage Diff           @@
##              2.x    #1327   +/-   ##
=======================================
  Coverage   51.61%   51.61%           
=======================================
  Files         305      305           
  Lines       10652    10653    +1     
  Branches     2789     2790    +1     
=======================================
+ Hits         5498     5499    +1     
  Misses       5108     5108           
  Partials       46       46           
Flag Coverage Δ
dashboards-observability 51.61% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pjfitzgibbons pjfitzgibbons merged commit 8e18097 into 2.x Dec 22, 2023
12 of 30 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to main failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-observability/backport-main main
# Navigate to the new working tree
pushd ../.worktrees/dashboards-observability/backport-main
# Create a new branch
git switch --create backport/backport-1327-to-main
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8e1809765ddcf507f8fa8802ec59c57592dca3fb
# Push it to GitHub
git push --set-upstream origin backport/backport-1327-to-main
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-observability/backport-main

Then, create a pull request where the base branch is main and the compare/head branch is backport/backport-1327-to-main.

pjfitzgibbons added a commit that referenced this pull request Dec 22, 2023
* Correct date pass-through on Notebook Visualizations.

Also fix an scss error.

---------

Signed-off-by: Peter Fitzgibbons <[email protected]>
(cherry picked from commit 8e18097)
amsiglan pushed a commit to amsiglan/dashboards-observability that referenced this pull request Jun 7, 2024
…ject#1327)

* Correct date pass-through on Notebook Visualizations.

Also fix an scss error.

---------

Signed-off-by: Peter Fitzgibbons <[email protected]>
(cherry picked from commit 8e18097)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants