-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct date pass-through on Notebook Visualizations. #1327
Conversation
Also fix an scss error. Signed-off-by: Peter Fitzgibbons <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #1327 +/- ##
=======================================
Coverage 51.61% 51.61%
=======================================
Files 305 305
Lines 10652 10653 +1
Branches 2789 2790 +1
=======================================
+ Hits 5498 5499 +1
Misses 5108 5108
Partials 46 46
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
public/components/notebooks/components/paragraph_components/__tests__/para_output.test.tsx
Outdated
Show resolved
Hide resolved
public/components/notebooks/components/paragraph_components/para_output.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Peter Fitzgibbons <[email protected]>
Signed-off-by: Peter Fitzgibbons <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-observability/backport-main main
# Navigate to the new working tree
pushd ../.worktrees/dashboards-observability/backport-main
# Create a new branch
git switch --create backport/backport-1327-to-main
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8e1809765ddcf507f8fa8802ec59c57592dca3fb
# Push it to GitHub
git push --set-upstream origin backport/backport-1327-to-main
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-observability/backport-main Then, create a pull request where the |
* Correct date pass-through on Notebook Visualizations. Also fix an scss error. --------- Signed-off-by: Peter Fitzgibbons <[email protected]> (cherry picked from commit 8e18097)
…ject#1327) * Correct date pass-through on Notebook Visualizations. Also fix an scss error. --------- Signed-off-by: Peter Fitzgibbons <[email protected]> (cherry picked from commit 8e18097)
Also fix an scss error.
Description
Notebook visualizations date pass-through from Notebook Paragraph is corrected.
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.