Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Modify autofollow retry scheduler logic check to account for completed runs (#839) #897

Merged

Conversation

saikaranam-amazon
Copy link
Member

Description

Modify autofollow retry scheduler logic check to account for completed runs (#839)

Issues Resolved

N/A

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Merging #897 (db0bfa2) into 2.x (57755ec) will increase coverage by 0.59%.
The diff coverage is 100.00%.

❗ Current head db0bfa2 differs from pull request most recent head 120d206. Consider uploading reports for the commit 120d206 to get more accurate results

@@             Coverage Diff              @@
##                2.x     #897      +/-   ##
============================================
+ Coverage     72.70%   73.30%   +0.59%     
- Complexity     1001     1008       +7     
============================================
  Files           141      141              
  Lines          4678     4678              
  Branches        514      514              
============================================
+ Hits           3401     3429      +28     
+ Misses          952      930      -22     
+ Partials        325      319       -6     
Impacted Files Coverage Δ
...arch/replication/task/autofollow/AutoFollowTask.kt 74.05% <100.00%> (+1.26%) ⬆️

... and 6 files with indirect coverage changes

@saikaranam-amazon saikaranam-amazon marked this pull request as ready for review May 31, 2023 05:01
@opensearch-trigger-bot
Copy link

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-897-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 689ae33791610d69dada452a466ee8795fd3bc23
# Push it to GitHub
git push --set-upstream origin backport/backport-897-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-897-to-2.x.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 2, 2023
…d runs (#839) (#897)

Signed-off-by: Sai Kumar <[email protected]>
(cherry picked from commit 689ae33)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 2, 2023
…d runs (#839) (#897)

Signed-off-by: Sai Kumar <[email protected]>
(cherry picked from commit 689ae33)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 2, 2023
…d runs (#839) (#897)

Signed-off-by: Sai Kumar <[email protected]>
(cherry picked from commit 689ae33)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 2, 2023
…d runs (#839) (#897)

Signed-off-by: Sai Kumar <[email protected]>
(cherry picked from commit 689ae33)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 2, 2023
…d runs (#839) (#897)

Signed-off-by: Sai Kumar <[email protected]>
(cherry picked from commit 689ae33)
saikaranam-amazon added a commit that referenced this pull request Jun 2, 2023
…d runs (#839) (#897) (#963)

(cherry picked from commit 689ae33)

Signed-off-by: Sai Kumar <[email protected]>
Co-authored-by: Sai Kumar <[email protected]>
saikaranam-amazon added a commit that referenced this pull request Jun 2, 2023
…d runs (#839) (#897) (#962)

(cherry picked from commit 689ae33)

Signed-off-by: Sai Kumar <[email protected]>
Co-authored-by: Sai Kumar <[email protected]>
saikaranam-amazon added a commit that referenced this pull request Jun 2, 2023
…d runs (#839) (#897) (#961)

(cherry picked from commit 689ae33)

Signed-off-by: Sai Kumar <[email protected]>
Co-authored-by: Sai Kumar <[email protected]>
saikaranam-amazon added a commit that referenced this pull request Jun 2, 2023
…d runs (#839) (#897) (#960)

(cherry picked from commit 689ae33)

Signed-off-by: Sai Kumar <[email protected]>
Co-authored-by: Sai Kumar <[email protected]>
saikaranam-amazon added a commit that referenced this pull request Jun 2, 2023
…d runs (#839) (#897) (#959)

(cherry picked from commit 689ae33)

Signed-off-by: Sai Kumar <[email protected]>
Co-authored-by: Sai Kumar <[email protected]>
saikaranam-amazon added a commit that referenced this pull request Jun 2, 2023
…d runs (#839) (#897) (#957)

(cherry picked from commit 689ae33)

Signed-off-by: Sai Kumar <[email protected]>
Co-authored-by: Sai Kumar <[email protected]>
saikaranam-amazon added a commit that referenced this pull request Jun 2, 2023
…d runs (#839) (#897) (#954)

(cherry picked from commit 689ae33)

Signed-off-by: Sai Kumar <[email protected]>
Co-authored-by: Sai Kumar <[email protected]>
saikaranam-amazon added a commit that referenced this pull request Jun 2, 2023
…d runs (#839) (#897) (#953)

(cherry picked from commit 689ae33)

Signed-off-by: Sai Kumar <[email protected]>
Co-authored-by: Sai Kumar <[email protected]>
saikaranam-amazon added a commit to saikaranam-amazon/cross-cluster-replication-2 that referenced this pull request Jun 2, 2023
saikaranam-amazon added a commit that referenced this pull request Jun 2, 2023
…d runs (#839) (#897) (#953) (#984)

(cherry picked from commit 689ae33)

Signed-off-by: Sai Kumar <[email protected]>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants