Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Accept of list of monitor ids in findings and alerts request dtos (#277) #278

Merged
merged 1 commit into from
Oct 10, 2022

Conversation

eirsep
Copy link
Member

@eirsep eirsep commented Oct 10, 2022

Backports #277 to 2.x
Signed-off-by: Surya Sashank Nistala [email protected]

@eirsep eirsep requested a review from a team October 10, 2022 21:37
@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2022

Codecov Report

Merging #278 (311d7f6) into 2.x (082c776) will increase coverage by 0.09%.
The diff coverage is 92.30%.

@@             Coverage Diff              @@
##                2.x     #278      +/-   ##
============================================
+ Coverage     72.37%   72.47%   +0.09%     
- Complexity      662      666       +4     
============================================
  Files           106      106              
  Lines          4406     4417      +11     
  Branches        601      601              
============================================
+ Hits           3189     3201      +12     
+ Misses          966      965       -1     
  Partials        251      251              
Impacted Files Coverage Δ
...arch/commons/alerting/action/GetFindingsRequest.kt 92.85% <85.71%> (+5.90%) ⬆️
...search/commons/alerting/action/GetAlertsRequest.kt 96.66% <100.00%> (+0.83%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@qreshi qreshi changed the title Accept of list of monitor ids in findings and alerts request dtos (#277) [Backport 2.x] Accept of list of monitor ids in findings and alerts request dtos (#277) Oct 10, 2022
@AWSHurneyt AWSHurneyt merged commit 16cf2b6 into opensearch-project:2.x Oct 10, 2022
wuychn pushed a commit to ochprince/common-utils that referenced this pull request Mar 16, 2023
AWSHurneyt pushed a commit to AWSHurneyt/common-utils that referenced this pull request Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants