Accept of list of monitor ids in findings and alerts request dtos #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Surya Sashank Nistala <[email protected]>
sbcd90
previously approved these changes
Oct 10, 2022
qreshi
reviewed
Oct 10, 2022
|
|
||
| class GetAlertsRequest : ActionRequest { | ||
| val table: Table | ||
| val severityLevel: String | ||
| val alertState: String | ||
| val monitorId: String? | ||
| val alertIndex: String? | ||
| val monitorIds: List<String>? |
There was a problem hiding this comment.
If we've defined monitorIds as nullable here, we should also make it nullable in the constructor (or non-nullable for both so it's consistent)
Same goes for the GetFindingsRequest
Signed-off-by: Surya Sashank Nistala <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #277 +/- ##
============================================
+ Coverage 71.42% 71.52% +0.09%
- Complexity 662 666 +4
============================================
Files 108 108
Lines 4466 4477 +11
Branches 605 605
============================================
+ Hits 3190 3202 +12
+ Misses 1025 1024 -1
Partials 251 251
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
qreshi
approved these changes
Oct 10, 2022
sbcd90
approved these changes
Oct 10, 2022
eirsep
added a commit
to eirsep/common-utils
that referenced
this pull request
Oct 10, 2022
…ensearch-project#277) Signed-off-by: Surya Sashank Nistala <[email protected]>
AWSHurneyt
pushed a commit
that referenced
this pull request
Oct 10, 2022
…) (#278) Signed-off-by: Surya Sashank Nistala <[email protected]> Signed-off-by: Surya Sashank Nistala <[email protected]>
wuychn
pushed a commit
to ochprince/common-utils
that referenced
this pull request
Mar 16, 2023
…ensearch-project#277) (opensearch-project#278) Signed-off-by: Surya Sashank Nistala <[email protected]> Signed-off-by: Surya Sashank Nistala <[email protected]>
AWSHurneyt
pushed a commit
to AWSHurneyt/common-utils
that referenced
this pull request
Apr 12, 2024
…ensearch-project#277) (opensearch-project#278) Signed-off-by: Surya Sashank Nistala <[email protected]> Signed-off-by: Surya Sashank Nistala <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Surya Sashank Nistala [email protected]
Relates to :
[FEATURE] Support fetching bulk alerts for multiple monitors in get alerts API #587
[FEATURE]Support fetching bulk findings for multiple monitors in get findings API #588