Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport main] Copy over monitor datasources config from alerting to common utils #271

Merged
merged 1 commit into from
Oct 7, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 3dce8f7 from #247

@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team October 7, 2022 17:17
@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2022

Codecov Report

Merging #271 (3cea0a8) into main (9c2621e) will decrease coverage by 0.23%.
The diff coverage is 64.00%.

@@             Coverage Diff              @@
##               main     #271      +/-   ##
============================================
- Coverage     75.06%   74.83%   -0.24%     
- Complexity      591      595       +4     
============================================
  Files            93       94       +1     
  Lines          3766     3838      +72     
  Branches        531      548      +17     
============================================
+ Hits           2827     2872      +45     
- Misses          721      738      +17     
- Partials        218      228      +10     
Impacted Files Coverage Δ
...g/opensearch/commons/alerting/model/DataSources.kt 62.29% <62.29%> (ø)
...n/org/opensearch/commons/alerting/model/Monitor.kt 80.97% <71.42%> (-1.11%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

)

* copy over monitor datasources config from alerting to common utils

Signed-off-by: Surya Sashank Nistala <[email protected]>
(cherry picked from commit 3dce8f7)
@lezzago lezzago force-pushed the backport/backport-247-to-main branch from 5c000cb to 3cea0a8 Compare October 7, 2022 17:24
@AWSHurneyt AWSHurneyt merged commit 03fd527 into main Oct 7, 2022
@github-actions github-actions bot deleted the backport/backport-247-to-main branch October 7, 2022 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants