Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy over monitor datasources config from alerting to common utils #247

Merged
merged 2 commits into from
Sep 12, 2022

Conversation

eirsep
Copy link
Member

@eirsep eirsep commented Sep 12, 2022

Signed-off-by: Surya Sashank Nistala [email protected]

Description

Copy over monitor datasources config from alerting to common utils

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@eirsep eirsep requested review from a team, getsaurabh02 and sbcd90 September 12, 2022 21:46
getsaurabh02
getsaurabh02 previously approved these changes Sep 12, 2022
Signed-off-by: Surya Sashank Nistala <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2022

Codecov Report

Merging #247 (42f06a2) into 2.x (587d9cb) will decrease coverage by 0.26%.
The diff coverage is 64.00%.

@@             Coverage Diff              @@
##                2.x     #247      +/-   ##
============================================
- Coverage     76.25%   75.99%   -0.27%     
- Complexity      591      595       +4     
============================================
  Files            91       92       +1     
  Lines          3706     3778      +72     
  Branches        527      544      +17     
============================================
+ Hits           2826     2871      +45     
- Misses          662      679      +17     
- Partials        218      228      +10     
Impacted Files Coverage Δ
...g/opensearch/commons/alerting/model/DataSources.kt 62.29% <62.29%> (ø)
...n/org/opensearch/commons/alerting/model/Monitor.kt 80.97% <71.42%> (-1.11%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@eirsep eirsep merged commit 3dce8f7 into opensearch-project:2.x Sep 12, 2022
petardz pushed a commit to petardz/common-utils that referenced this pull request Sep 21, 2022
…pensearch-project#247)

* copy over monitor datasources config from alerting to common utils

Signed-off-by: Surya Sashank Nistala <[email protected]>
Signed-off-by: Petar Dzepina <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 7, 2022
)

* copy over monitor datasources config from alerting to common utils

Signed-off-by: Surya Sashank Nistala <[email protected]>
(cherry picked from commit 3dce8f7)
lezzago pushed a commit that referenced this pull request Oct 7, 2022
)

* copy over monitor datasources config from alerting to common utils

Signed-off-by: Surya Sashank Nistala <[email protected]>
(cherry picked from commit 3dce8f7)
AWSHurneyt pushed a commit that referenced this pull request Oct 7, 2022
) (#271)

* copy over monitor datasources config from alerting to common utils

Signed-off-by: Surya Sashank Nistala <[email protected]>
(cherry picked from commit 3dce8f7)

Co-authored-by: Surya Sashank Nistala <[email protected]>
wuychn pushed a commit to ochprince/common-utils that referenced this pull request Mar 16, 2023
…pensearch-project#247)

* copy over monitor datasources config from alerting to common utils

Signed-off-by: Surya Sashank Nistala <[email protected]>
AWSHurneyt pushed a commit to AWSHurneyt/common-utils that referenced this pull request Apr 12, 2024
…pensearch-project#247)

* copy over monitor datasources config from alerting to common utils

Signed-off-by: Surya Sashank Nistala <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants