-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature/extensions] Add getSettings support for AD #686
[Feature/extensions] Add getSettings support for AD #686
Conversation
Signed-off-by: Daniel Widdis <[email protected]>
@dbwiddis build is failing |
@owaiskazi19 Build is failing because SDK #163 changed the API. You would need to change other code here to comply with that new API. However, don't bother with that, because 169 and 4705 will change it again. So this is currently blocked by those other PRs. Suggestion:
|
Updated the RestCreateDetectorAction (which was just a copy of hello world) with the new version of Hello World. Tests should pass once both 4705 and 169 are merged. |
169 and 4705 merged, should be able to re-run the tests now. |
@saratvemulapalli can you take of it? I don't have access to rerun the test for AD. |
Kicked them off. |
Will probably have to do that. I think the rerun is not pulling the updated branches. |
Signed-off-by: Daniel Widdis <[email protected]>
b08cc84
to
1deb649
Compare
Well now it's failing on something else entirely, probably something commented out that's still being tested. I give up. |
Relevant comments:
|
Signed-off-by: Daniel Widdis <[email protected]>
All green. And this, kids, is why you pay attention to those little IDE flags that say you're using deprecated code. :-) |
OK, ready to merge. I'm getting confused by this same fix not working on main here, but I'm not sure it's broken (yet) on main here. |
Description
Copies the
getSettings()
method impelmentation fromAnomalyDetectorPlugin
toAnomalyDetectorExtension
. This is the third and final step to complete work already done in SDK #147 and and OS #4519 register AD settings with OpenSearchIssues Resolved
Fixes SDK #159
Relates to SDK #132
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.