Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] AD doesn't compile: BaseNodeRequest class has been removed #687

Closed
dbwiddis opened this issue Oct 11, 2022 · 3 comments
Closed

[BUG] AD doesn't compile: BaseNodeRequest class has been removed #687

dbwiddis opened this issue Oct 11, 2022 · 3 comments
Labels
bug Something isn't working untriaged

Comments

@dbwiddis
Copy link
Member

dbwiddis commented Oct 11, 2022

What is the bug?

Classes extending BaseNodeRequest now produce compile errors.

How can one reproduce the bug?

Compile against OpenSearch main branch (3.0.0 snapshot dependency)

What is the expected behavior?
Code compiles

What is your host/environment?
Jenkins CI on this project

Do you have any screenshots?
https://github.com/opensearch-project/anomaly-detection/actions/runs/3223621043/jobs/5273892781

Do you have any additional context?
#4702 removed the (deprecated) BaseNodeRequest class.
Relevant comments:

* @deprecated this class is deprecated and classes will extend TransportRequest directly
 */
// TODO: this class can be removed in main once 7.x is bumped to 7.4.0

I attempted to fix in #688 with a cherry-pick of this commit: b979359

But it seems the new TransportNodesAction class signature (also updated in that PR) isn't getting pulled into the dependency and is still using an old copy of the class.

@dbwiddis
Copy link
Member Author

OK, I'm confused. I think you're pulling from an older external dependency here, while on feature/extensions we're pulling from main. So this is not a bug yet but it will become one when you update to the next version of OpenSearch...

@amitgalitz
Copy link
Member

Hi @dbwiddis we fixed this on main branch, feel free to close this issue if you confirmed on your end that this isn't blocking the extensions work

@dbwiddis
Copy link
Member Author

I fixed it on our extensions branch in #686, I was just trying to be helpful and copy that fix here... I think we're all in sync now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working untriaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants