[CI] Fetch OpenSearch version in same step #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Ohlsen <[email protected]>
ohltyler
requested review from
kaituo,
jackiehanyang,
amitgalitz and
sean-zheng-amazon
as code owners
opensearch-trigger-bot
bot
added
github actions
ohltyler
changed the title
1 task
Codecov Report
@@ Coverage Diff @@
## main #556 +/- ##
=======================================
Coverage 50.25% 50.25%
=======================================
Files 166 166
Lines 5593 5593
Branches 1055 1055
=======================================
Hits 2811 2811
Misses 2511 2511
Partials 271 271 |
amitgalitz
approved these changes
Jul 18, 2023
kaituo
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fetch version in the same step so the env variable is always resolved. Previous PR #554 this was not guaranteed and could fail.
This is already fixed in the manual backport to 2.x: #555
Issues Resolved
[List any issues this PR will resolve]
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.