-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove version dependency in cypress workflow #554
Merged
ohltyler
merged 7 commits into
opensearch-project:main
from
ohltyler:remove-version-dep
Jul 13, 2023
Merged
Remove version dependency in cypress workflow #554
ohltyler
merged 7 commits into
opensearch-project:main
from
ohltyler:remove-version-dep
Jul 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Ohlsen <[email protected]>
ohltyler
requested review from
kaituo,
jackiehanyang,
amitgalitz and
sean-zheng-amazon
as code owners
July 13, 2023 22:25
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #554 +/- ##
==========================================
- Coverage 51.98% 50.25% -1.73%
==========================================
Files 149 166 +17
Lines 5030 5593 +563
Branches 983 1055 +72
==========================================
+ Hits 2615 2811 +196
- Misses 2156 2511 +355
- Partials 259 271 +12 |
Signed-off-by: Tyler Ohlsen <[email protected]>
kaituo
approved these changes
Jul 13, 2023
jackiehanyang
approved these changes
Jul 13, 2023
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-554-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e6d15ecb1a906c0e1c9f2d25286aeca1fcb1f8dc
# Push it to GitHub
git push --set-upstream origin backport/backport-554-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
ohltyler
added a commit
to ohltyler/anomaly-detection-dashboards-plugin-1
that referenced
this pull request
Jul 13, 2023
Signed-off-by: Tyler Ohlsen <[email protected]>
1 task
ohltyler
added a commit
to ohltyler/anomaly-detection-dashboards-plugin-1
that referenced
this pull request
Jul 14, 2023
Signed-off-by: Tyler Ohlsen <[email protected]>
4 tasks
ohltyler
added a commit
that referenced
this pull request
Jul 18, 2023
…555) Signed-off-by: Tyler Ohlsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove version dependency in cypress workflow by fetching the OpenSearch version value from config file. Now, the auto-created version bump PRs should be sufficient to update all places where versions need bumped.
Moved around steps a bit so the version could be fetched before spinning up OpenSearch cluster
Check List
--signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.