Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update actionGet to SuspendUntil for ClusterMetrics #1067

Merged

Conversation

lezzago
Copy link
Member

@lezzago lezzago commented Aug 2, 2023

Issue #, if available:
N/A

Description of changes:
Update actionGet to SuspendUntil for ClusterMetrics API calls

CheckList:

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #1067 (bce9b1d) into main (5fbb18a) will decrease coverage by 5.00%.
The diff coverage is 12.50%.

@@             Coverage Diff              @@
##               main    #1067      +/-   ##
============================================
- Coverage     72.57%   67.58%   -5.00%     
  Complexity      105      105              
============================================
  Files           160      160              
  Lines         10324    10325       +1     
  Branches       1518     1518              
============================================
- Hits           7493     6978     -515     
- Misses         1971     2685     +714     
+ Partials        860      662     -198     
Files Changed Coverage Δ
...lpers/SupportedClusterMetricsSettingsExtensions.kt 23.28% <12.50%> (-30.88%) ⬇️

... and 9 files with indirect coverage changes

@lezzago
Copy link
Member Author

lezzago commented Aug 2, 2023

Unrelated test is failing in multinode: org.opensearch.alerting.resthandler.WorkflowRestApiIT.test chained alerts and audit alerts for workflows with query level monitor
@eirsep

@lezzago lezzago added backport 2.x backport 2.9 backports PRs to 2.9 labels Aug 2, 2023
@AWSHurneyt
Copy link
Collaborator

This PR addresses one of the follow-up items listed in issue #1006

@AWSHurneyt AWSHurneyt merged commit 3baf51a into opensearch-project:main Aug 2, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 2, 2023
Signed-off-by: Ashish Agrawal <[email protected]>
(cherry picked from commit 3baf51a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 2, 2023
Signed-off-by: Ashish Agrawal <[email protected]>
(cherry picked from commit 3baf51a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
lezzago pushed a commit that referenced this pull request Aug 2, 2023
(cherry picked from commit 3baf51a)

Signed-off-by: Ashish Agrawal <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
lezzago pushed a commit that referenced this pull request Aug 2, 2023
(cherry picked from commit 3baf51a)

Signed-off-by: Ashish Agrawal <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport 2.9 backports PRs to 2.9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants