Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Cluster metrics monitor enhancement follow-up items #1006

Open
AWSHurneyt opened this issue Jul 11, 2023 · 2 comments
Open

[FEATURE] Cluster metrics monitor enhancement follow-up items #1006

AWSHurneyt opened this issue Jul 11, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@AWSHurneyt
Copy link
Collaborator

AWSHurneyt commented Jul 11, 2023

There were non-blocking action items leftover from the enhancement PR (#992). The action items include:

  1. Adding javadoc comments to better explain the logic in the various helper methods
  2. Enhancing the tests by calling the actual cat API to compare that response to the monitor execution response.
  3. Resolve the issues that are blocking us from refactoring calls to .get() to .suspendUntil(). Ref
  4. Add integration tests for all supported API, including path parameters. Related Implement additional testing for ClusterMetrics Monitors alerting-dashboards-plugin#186
@AWSHurneyt
Copy link
Collaborator Author

To reduce code duplication, it would also be worthwhile to create an issue in the core repo to ask that the request and response object creation from the API rest handlers be extracted to helper methods that are accessible outside of the rest handler classes.

@AWSHurneyt
Copy link
Collaborator Author

AWSHurneyt commented Oct 14, 2024

To reduce code duplication, it would also be worthwhile to create an issue in the core repo to ask that the request and response object creation from the API rest handlers be extracted to helper methods that are accessible outside of the rest handler classes.

May need to investigate whether this is still viable. The _cat/indices, and _cat/shards API are not longer available on large domains. To support the new _list API, cluster metrics monitors would need to be enhanced to support query params (e.g., the next_token, and size params mentioned in the below issues).

Those changes should not impact the current cluster metrics monitors implementation as _cat/indices, and _cat/shards monitors do not call those API directly; they instead mimic the sequence of calls made by those API.
https://github.com/opensearch-project/alerting/blob/main/alerting/src/main/kotlin/org/opensearch/alerting/util/clusterMetricsMonitorHelpers/SupportedClusterMetricsSettingsExtensions.kt#L47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants