[#7101] Fixing the GeoTileIT#testMultivaluedGeoPointsAggregation testcase

[navneet1v]

Description

Fixing the GeoTileIT#testMultivaluedGeoPointsAggregation testcase

The issue was happening because we encode the GeoPoint as long and error comes in the precision due to that encoding. The error was not taken care while generating the exepected tiles count for expected output. The error was happening for a tile: 13/1627/7465

Solution

The idea to fix this is simple enough, while generating the expected buckets for geo-points I will encode and decode the lat-lon values. This will make sure that the precision loss comes in during the Tile creation, as showed in the below snippet.

Code ref:

OpenSearch/modules/geo/src/internalClusterTest/java/org/opensearch/geo/search/aggregations/bucket/GeoTileGridIT.java

Lines 160 to 166 in 9386cde

	protected Set<String> generateBucketsForGeoPoint(final GeoPoint geoPoint) {
	Set<String> buckets = new HashSet<>();
	for (int precision = GEOPOINT_MAX_PRECISION; precision > 0; precision--) {
	final String tile = GeoTileUtils.stringEncode(geoPoint.getLon(), geoPoint.getLat(), precision);
	buckets.add(tile);
	}
	return buckets;

protected Set<String> generateBucketsForGeoPoint(final GeoPoint geoPoint) {
        Set<String> buckets = new HashSet<>();
        for (int precision = GEOPOINT_MAX_PRECISION; precision > 0; precision--) {
            final String tile =
                    GeoTileUtils.stringEncode(GeoEncodingUtils.decodeLongitude(GeoEncodingUtils.encodeLongitude(geoPoint.getLon())), GeoEncodingUtils.decodeLatitude(GeoEncodingUtils.encodeLatitude(geoPoint.getLat())), precision);
            buckets.add(tile);
        }
        return buckets;
    }

Tested by running:

./gradlew ':modules:geo:internalClusterTest' --tests "org.opensearch.geo.search.aggregations.bucket.GeoTileGridIT.testMultivaluedGeoPointsAggregation" -Dtests.seed=73A6EB980B2F13B4 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=is -Dtests.timezone=Africa/Addis_Ababa

Issues Resolved

#7101

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/14051/
• CommitID: c041702
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[navneet1v]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/14051/
• CommitID: c041702
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

Flaky tests. Issues: https://github.com/opensearch-project/OpenSearch/issues?q=is%3Aissue+is%3Aopen+MixedClusterClientYamlTestSuiteIT

[navneet1v]

@nknize can you help review this PR.

[dblock]

This is fine, but does feel a little hacky. Perhaps, adding a function that rounds the lon/lat explicitly to avoid the precision problem would make it clearer?

[navneet1v]

This is fine, but does feel a little hacky. Perhaps, adding a function that rounds the lon/lat explicitly to avoid the precision problem would make it clearer?

Let me abstract this call under a private function, so that this logic is not exposed in the tests. @dblock does that work?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/14151/
• CommitID: c041702
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/14165/
• CommitID: 2a8bffa
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/14158/
• CommitID: e3ad558
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[nknize]

Let me abstract this call under a private function,

+1.. we do this on Lucene as a protected Encoder to ensure the expected test coordinates match the quantized spatial values retrieved from the docvalue / index. Once we add support for XYShape we'll want to abstract this in a similar manner.

[navneet1v]

Let me abstract this call under a private function,

+1.. we do this on Lucene as a protected Encoder to ensure the expected test coordinates match the quantized spatial values retrieved from the docvalue / index. Once we add support for XYShape we'll want to abstract this in a similar manner.

I have abstracted this atleast for tests.

[navneet1v]

@nknize , @dblock can we merge this?

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-7166-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 48975828fd9a2bc8e5a792b6c0646dd99b75c124
# Push it to GitHub
git push --set-upstream origin backport/backport-7166-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-7166-to-2.x.

[navneet1v]

Removing backport label, as this tests case currently not present in 2.x