Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] GeoTileGridIT.testGeoShapes failure #6187

Closed
andrross opened this issue Feb 4, 2023 · 8 comments
Closed

[BUG] GeoTileGridIT.testGeoShapes failure #6187

andrross opened this issue Feb 4, 2023 · 8 comments
Labels
bug Something isn't working Geospatial >test-failure Test failure from CI, local build, etc.

Comments

@andrross
Copy link
Member

andrross commented Feb 4, 2023

Seems to be reproducible:

./gradlew ':modules:geo:internalClusterTest' --tests "org.opensearch.geo.search.aggregations.bucket.GeoTileGridIT.testGeoShapes" -Dtests.seed=EC3F504EF22998E0

org.opensearch.geo.search.aggregations.bucket.GeoTileGridIT > testGeoShapes FAILED
    java.lang.AssertionError: Geotile 3/7/4 has wrong doc count  expected:<36> but was:<1>
        at __randomizedtesting.SeedInfo.seed([EC3F504EF22998E0:682E8817D55CBFD]:0)
        at org.junit.Assert.fail(Assert.java:89)
        at org.junit.Assert.failNotEquals(Assert.java:835)
        at org.junit.Assert.assertEquals(Assert.java:647)
        at org.opensearch.geo.search.aggregations.bucket.GeoTileGridIT.testGeoShapes(GeoTileGridIT.java:78)

https://build.ci.opensearch.org/job/gradle-check/10625/consoleFull

/cc @navneet1v
@andrross andrross added bug Something isn't working untriaged labels Feb 4, 2023
@andrross andrross mentioned this issue Feb 4, 2023
Merged
6 tasks
@andrross andrross added the >test-failure Test failure from CI, local build, etc. label Feb 4, 2023
@navneet1v
Copy link
Contributor

Did you pull in the latest change? We have recently fixed this flaky tests

@andrross
Copy link
Member Author

andrross commented Feb 4, 2023

See the build log, but it was built against this commit, which includes some recent changes to that test.

@navneet1v
Copy link
Contributor

Let me check again. We recently fixed the tests again.

@dbwiddis dbwiddis mentioned this issue Feb 7, 2023
Merged
3 tasks
@andrross
Copy link
Member Author

andrross commented Feb 7, 2023

@navneet1v The change from #6120 was present in the failed build above. I also opened #6222 for a test failure in GeoHashGridIT that had the change from #6120 as well.

@ashking94
Copy link
Member

Facing build failures on PR builds - https://build.ci.opensearch.org/job/gradle-check/10797/#showFailuresLink. Let's mute these until fixed?

@navneet1v
Copy link
Contributor

I am doing the final tests. The PR will be out soon.

navneet1v added a commit to navneet1v/OpenSearch that referenced this issue Feb 8, 2023
@navneet1v
[opensearch-project#6187, opensearch-project#6222] Fixing the GeoShap…
77a1f0e 
…es GeoHash and GeoTile Aggregations Integration tests to make them more robust.

Signed-off-by: Navneet Verma <[email protected]>
@navneet1v navneet1v mentioned this issue Feb 8, 2023
Merged
6 tasks
@navneet1v
Copy link
Contributor

navneet1v commented Feb 8, 2023 •
edited
Loading

@ashking94 PR is out. #6242

navneet1v added a commit to navneet1v/OpenSearch that referenced this issue Feb 8, 2023
@navneet1v
[opensearch-project#6187, opensearch-project#6222] Fixing the GeoShap…
facb25a 
…es GeoHash and GeoTile Aggregations Integration tests to make them more robust.

Signed-off-by: Navneet Verma <[email protected]>
navneet1v added a commit to navneet1v/OpenSearch that referenced this issue Feb 9, 2023
@navneet1v
[opensearch-project#6187, opensearch-project#6222] Fixing the GeoShap…
0c011cf 
…es GeoHash and GeoTile Aggregations Integration tests.

Changes done:
* Fixed the ArrayIndexOutOfBoundsException.
* Reduced the precision for GeoShapes Aggregation IT testing.

Signed-off-by: Navneet Verma <[email protected]>
navneet1v added a commit to navneet1v/OpenSearch that referenced this issue Feb 9, 2023
@navneet1v
[opensearch-project#6187, opensearch-project#6222] Fixing the GeoShap…
f139318 
…es GeoHash and GeoTile Aggregations Integration tests.

Changes done:
* Fixed the ArrayIndexOutOfBoundsException.
* Reduced the precision for GeoShapes Aggregation IT testing.

Signed-off-by: Navneet Verma <[email protected]>
nknize pushed a commit that referenced this issue Feb 10, 2023
@navneet1v
[#6187, #6222] Fixing the GeoShapes GeoHash and GeoTile Aggregations …
9386cde 
…Integration tests. (#6242)

Changes done:
* Fixed the ArrayIndexOutOfBoundsException.
* Reduced the precision for GeoShapes Aggregation IT testing.

Signed-off-by: Navneet Verma <[email protected]>
@navneet1v
Copy link
Contributor

The PR is merged. Resolving the issue.

heemin32 pushed a commit to heemin32/OpenSearch that referenced this issue Jun 28, 2023
@navneet1v @heemin32
[opensearch-project#6187, opensearch-project#6222] Fixing the GeoShap…
9105f0c 
…es GeoHash and GeoTile Aggregations Integration tests. (opensearch-project#6242)

Changes done:
* Fixed the ArrayIndexOutOfBoundsException.
* Reduced the precision for GeoShapes Aggregation IT testing.

Signed-off-by: Navneet Verma <[email protected]>
andrross pushed a commit that referenced this issue Jun 30, 2023
@heemin32 @navneet1v
[Backport 2.x] GeoTile, and GeoGrid aggregation (#8295)
0dbafea 
* Add GeoTile and GeoHash Grid aggregations on GeoShapes. (#5589)

Src files for GeoTile and GeoHash Aggregations on GeoShape with integration
tests.

Signed-off-by: Navneet Verma <[email protected]>

* [opensearch-project/geospatial#212] Fixing the IT for GeoTilesAggrega… (#6120)

Fixing the IT for GeoTilesAggregation.

Signed-off-by: Navneet Verma <[email protected]>

* [#6187, #6222] Fixing the GeoShapes GeoHash and GeoTile Aggregations Integration tests. (#6242)

Changes done:
* Fixed the ArrayIndexOutOfBoundsException.
* Reduced the precision for GeoShapes Aggregation IT testing.

Signed-off-by: Navneet Verma <[email protected]>

* [#7101] Fixing the GeoTileIT#testMultivaluedGeoPointsAggregation test case. (#7166)

The issue was happening because we encode the GeoPoint as long and error comes in the precision due to that encoding. The error was not taken care while generating the exepected tiles count for execpected output.

Signed-off-by: Navneet Verma <[email protected]>

---------

Signed-off-by: Navneet Verma <[email protected]>
Signed-off-by: Heemin Kim <[email protected]>
Co-authored-by: Navneet Verma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Geospatial >test-failure Test failure from CI, local build, etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@navneet1v @andrross @ashking94