Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] [2.6] fix for updating version numbers for deprecation messages (#4719) (#6848) #6974

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

reta
Copy link
Collaborator

@reta reta commented Apr 4, 2023

(cherry picked from commit 16797d6)

Description

Backport to 2.6 since 2.x BWC tests fail:

java.lang.AssertionError: Failure at [indices.split/30_copy_settings:38]: got unexpected warning header [
	299 OpenSearch-2.6.1-SNAPSHOT-5bbb99a68463779301eb9c34be1add1d6d1d4614 "parameter [copy_settings] is deprecated and will be removed in 8.0.0"
]

Issues Resolved

See please https://build.ci.opensearch.org/job/gradle-check/13326/testReport/junit/org.opensearch.backwards/MixedClusterClientYamlTestSuiteIT/test__p0_indices_split_30_copy_settings_Copy_settings_during_split_index_/

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…-project#4719) (opensearch-project#6848)

(cherry picked from commit 16797d6)

Signed-off-by: Amit Chakraborti <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@reta reta changed the title fix for updating version numbers for deprecation messages (#4719) (#6… [Backport] [2.6] fix for updating version numbers for deprecation messages (#4719) (#6… Apr 4, 2023
@reta reta changed the title [Backport] [2.6] fix for updating version numbers for deprecation messages (#4719) (#6… [Backport] [2.6] fix for updating version numbers for deprecation messages (#4719) (#6848) Apr 4, 2023
@reta reta added the backport PRs or issues specific to backporting features or enhancments label Apr 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2023

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

Codecov Report

Merging #6974 (04eec31) into 2.6 (5bbb99a) will increase coverage by 0.14%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##                2.6    #6974      +/-   ##
============================================
+ Coverage     70.38%   70.52%   +0.14%     
- Complexity    59204    59267      +63     
============================================
  Files          4796     4796              
  Lines        284124   284124              
  Branches      41299    41299              
============================================
+ Hits         199980   200381     +401     
+ Misses        67414    66985     -429     
- Partials      16730    16758      +28     
Impacted Files Coverage Δ
...pensearch/ingest/useragent/UserAgentProcessor.java 61.58% <ø> (-1.83%) ⬇️
...ensearch/index/mapper/ParametrizedFieldMapper.java 98.59% <ø> (ø)
.../java/org/opensearch/index/mapper/TypeParsers.java 81.39% <ø> (ø)
...h/rest/action/admin/indices/RestResizeHandler.java 67.64% <ø> (ø)
...va/org/opensearch/index/mapper/MapperTestCase.java 95.81% <ø> (ø)
...g/opensearch/test/rest/OpenSearchRestTestCase.java 3.93% <ø> (ø)

... and 509 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dblock dblock merged commit a5d1638 into opensearch-project:2.6 Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PRs or issues specific to backporting features or enhancments skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants