-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/2659 deprecation messages updated #4719
Fix/2659 deprecation messages updated #4719
Conversation
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
I think we want to be specific like before with ES 8.0. We remove deprecations in the next major version, which will be 3.0? |
Signed-off-by: Amit Chakraborti <[email protected]>
cab5cb0
to
e6eff2d
Compare
Should I reframe the messages from "...is deprecated and will be removed in 8.0." to "...is deprecated and will be removed in 3.0"? |
Gradle Check (Jenkins) Run Completed with:
|
I think so, yes. |
Hi @amitchakraborti9 , could you please share latest status on this PR and progress? Please reach out if you need any help? Thanks |
e6eff2d
to
73a2279
Compare
I will be updating the PR today with this change today wherever "is deprecated and will be removed in 8.0" is mentioned.
|
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Amit Chakraborti <[email protected]>
I have made a new commit on the current version. |
Gradle Check (Jenkins) Run Completed with:
|
1 similar comment
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #4719 +/- ##
============================================
- Coverage 71.22% 70.83% -0.39%
+ Complexity 59521 59173 -348
============================================
Files 4803 4803
Lines 283208 283208
Branches 40842 40842
============================================
- Hits 201712 200623 -1089
- Misses 65266 66111 +845
- Partials 16230 16474 +244
... and 464 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you @amitchakraborti9 for fixing this.
@dblock : Please have a look. Let know if you have any concerns. |
Signed-off-by: Amit Chakraborti <[email protected]> (cherry picked from commit 16797d6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-1.x 1.x
# Navigate to the new working tree
pushd ../.worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-4719-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 16797d658125a8c28ddf49413222f30675352dd6
# Push it to GitHub
git push --set-upstream origin backport/backport-4719-to-1.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-1.x Then, create a pull request where the |
…-project#4719) Signed-off-by: Amit Chakraborti <[email protected]> (cherry picked from commit 16797d6)
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-1.3 1.3
# Navigate to the new working tree
pushd ../.worktrees/backport-1.3
# Create a new branch
git switch --create backport/backport-4719-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 16797d658125a8c28ddf49413222f30675352dd6
# Push it to GitHub
git push --set-upstream origin backport/backport-4719-to-1.3
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-1.3 Then, create a pull request where the |
…-project#4719) Signed-off-by: Amit Chakraborti <[email protected]> (cherry picked from commit 16797d6) Signed-off-by: Andriy Redko <[email protected]>
…-project#4719) Signed-off-by: Amit Chakraborti <[email protected]> (cherry picked from commit 16797d6) Signed-off-by: Andriy Redko <[email protected]>
) (cherry picked from commit 16797d6) Signed-off-by: Amit Chakraborti <[email protected]> Signed-off-by: Andriy Redko <[email protected]> Co-authored-by: Amit Chakraborti <[email protected]>
…-project#4719) Signed-off-by: Amit Chakraborti <[email protected]> (cherry picked from commit 16797d6) Signed-off-by: Andriy Redko <[email protected]>
) (cherry picked from commit 16797d6) Signed-off-by: Amit Chakraborti <[email protected]> Signed-off-by: Andriy Redko <[email protected]> Co-authored-by: Amit Chakraborti <[email protected]>
) (cherry picked from commit 16797d6) Signed-off-by: Amit Chakraborti <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…-project#4719) (opensearch-project#6848) (cherry picked from commit 16797d6) Signed-off-by: Amit Chakraborti <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
) (#6974) (cherry picked from commit 16797d6) Signed-off-by: Amit Chakraborti <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…-project#4719) Signed-off-by: Amit Chakraborti <[email protected]> Signed-off-by: Valentin Mitrofanov <[email protected]>
Description
Some deprecation messages refer to Elasticsearch version 8.0. Now they do not refer to Elasticsearch.
Issues Resolved
Issue #2659
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.