Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/2659 deprecation messages updated #4719

Conversation

amitchakraborti9
Copy link
Contributor

@amitchakraborti9 amitchakraborti9 commented Oct 10, 2022

Description

Some deprecation messages refer to Elasticsearch version 8.0. Now they do not refer to Elasticsearch.

Issues Resolved

Issue #2659

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@amitchakraborti9 amitchakraborti9 requested review from a team and reta as code owners October 10, 2022 07:45
amitchakraborti9 added a commit to amitchakraborti9/OpenSearch that referenced this pull request Oct 10, 2022
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@tlfeng tlfeng added enhancement Enhancement or improvement to existing feature or request hacktoberfest Global event that encourages people to contribute to open-source. labels Oct 10, 2022
@dblock
Copy link
Member

dblock commented Oct 11, 2022

I think we want to be specific like before with ES 8.0. We remove deprecations in the next major version, which will be 3.0?

amitchakraborti9 added a commit to amitchakraborti9/OpenSearch that referenced this pull request Oct 14, 2022
@amitchakraborti9 amitchakraborti9 force-pushed the fix/2659-Deprecation-messages-updated branch from cab5cb0 to e6eff2d Compare October 14, 2022 05:49
@amitchakraborti9
Copy link
Contributor Author

Should I reframe the messages from "...is deprecated and will be removed in 8.0." to "...is deprecated and will be removed in 3.0"?

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@dblock
Copy link
Member

dblock commented Oct 19, 2022

Should I reframe the messages from "...is deprecated and will be removed in 8.0." to "...is deprecated and will be removed in 3.0"?

I think so, yes.

@minalsha
Copy link
Contributor

Hi @amitchakraborti9 , could you please share latest status on this PR and progress? Please reach out if you need any help? Thanks

@amitchakraborti9 amitchakraborti9 force-pushed the fix/2659-Deprecation-messages-updated branch from e6eff2d to 73a2279 Compare March 14, 2023 05:40
@amitchakraborti9
Copy link
Contributor Author

I will be updating the PR today with this change today wherever "is deprecated and will be removed in 8.0" is mentioned.

Should I reframe the messages from "...is deprecated and will be removed in 8.0." to "...is deprecated and will be removed in 3.0"?

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@amitchakraborti9
Copy link
Contributor Author

I have made a new commit on the current version.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      2 org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=indices.shrink/30_copy_settings/Copy settings during shrink index}

1 similar comment
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      2 org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=indices.shrink/30_copy_settings/Copy settings during shrink index}

@codecov-commenter
Copy link

Codecov Report

Merging #4719 (d8af97a) into main (73a2279) will decrease coverage by 0.39%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main    #4719      +/-   ##
============================================
- Coverage     71.22%   70.83%   -0.39%     
+ Complexity    59521    59173     -348     
============================================
  Files          4803     4803              
  Lines        283208   283208              
  Branches      40842    40842              
============================================
- Hits         201712   200623    -1089     
- Misses        65266    66111     +845     
- Partials      16230    16474     +244     
Impacted Files Coverage Δ
...pensearch/ingest/useragent/UserAgentProcessor.java 63.41% <ø> (ø)
...ensearch/index/mapper/ParametrizedFieldMapper.java 98.59% <ø> (ø)
.../java/org/opensearch/index/mapper/TypeParsers.java 81.39% <ø> (ø)
...h/rest/action/admin/indices/RestResizeHandler.java 67.64% <ø> (ø)
...va/org/opensearch/index/mapper/MapperTestCase.java 95.81% <ø> (ø)
...g/opensearch/test/rest/OpenSearchRestTestCase.java 4.04% <ø> (ø)

... and 464 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@dreamer-89 dreamer-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @amitchakraborti9 for fixing this.

@dreamer-89
Copy link
Member

@dblock : Please have a look. Let know if you have any concerns.

@dblock dblock merged commit 16797d6 into opensearch-project:main Mar 27, 2023
@dblock dblock added the backport 2.x Backport to 2.x branch label Mar 27, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 27, 2023
Signed-off-by: Amit Chakraborti <[email protected]>
(cherry picked from commit 16797d6)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot
Copy link
Contributor

The backport to 1.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-1.x 1.x
# Navigate to the new working tree
pushd ../.worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-4719-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 16797d658125a8c28ddf49413222f30675352dd6
# Push it to GitHub
git push --set-upstream origin backport/backport-4719-to-1.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-1.x

Then, create a pull request where the base branch is 1.x and the compare/head branch is backport/backport-4719-to-1.x.

reta pushed a commit to reta/OpenSearch that referenced this pull request Mar 29, 2023
@reta reta added the backport 1.3 Backport to 1.3 branch label Mar 29, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 1.3 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-1.3 1.3
# Navigate to the new working tree
pushd ../.worktrees/backport-1.3
# Create a new branch
git switch --create backport/backport-4719-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 16797d658125a8c28ddf49413222f30675352dd6
# Push it to GitHub
git push --set-upstream origin backport/backport-4719-to-1.3
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-1.3

Then, create a pull request where the base branch is 1.3 and the compare/head branch is backport/backport-4719-to-1.3.

reta pushed a commit to reta/OpenSearch that referenced this pull request Mar 29, 2023
…-project#4719)

Signed-off-by: Amit Chakraborti <[email protected]>
(cherry picked from commit 16797d6)
Signed-off-by: Andriy Redko <[email protected]>
reta pushed a commit to reta/OpenSearch that referenced this pull request Mar 29, 2023
…-project#4719)

Signed-off-by: Amit Chakraborti <[email protected]>
(cherry picked from commit 16797d6)
Signed-off-by: Andriy Redko <[email protected]>
reta added a commit that referenced this pull request Mar 29, 2023
)

(cherry picked from commit 16797d6)

Signed-off-by: Amit Chakraborti <[email protected]>
Signed-off-by: Andriy Redko <[email protected]>
Co-authored-by: Amit Chakraborti <[email protected]>
reta pushed a commit to reta/OpenSearch that referenced this pull request Mar 29, 2023
…-project#4719)

Signed-off-by: Amit Chakraborti <[email protected]>
(cherry picked from commit 16797d6)
Signed-off-by: Andriy Redko <[email protected]>
kotwanikunal pushed a commit that referenced this pull request Mar 29, 2023
)

(cherry picked from commit 16797d6)

Signed-off-by: Amit Chakraborti <[email protected]>
Signed-off-by: Andriy Redko <[email protected]>
Co-authored-by: Amit Chakraborti <[email protected]>
reta pushed a commit that referenced this pull request Mar 30, 2023
)

(cherry picked from commit 16797d6)

Signed-off-by: Amit Chakraborti <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta pushed a commit to reta/OpenSearch that referenced this pull request Apr 4, 2023
…-project#4719) (opensearch-project#6848)

(cherry picked from commit 16797d6)

Signed-off-by: Amit Chakraborti <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dblock pushed a commit that referenced this pull request Apr 4, 2023
) (#6974)

(cherry picked from commit 16797d6)

Signed-off-by: Amit Chakraborti <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mitrofmep pushed a commit to mitrofmep/OpenSearch that referenced this pull request Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.x backport 1.3 Backport to 1.3 branch backport 2.x Backport to 2.x branch enhancement Enhancement or improvement to existing feature or request hacktoberfest Global event that encourages people to contribute to open-source. skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants