Fix IndexShardTests.testRestoreShardFromRemoteStore on Windows.

[mch2]

Signed-off-by: Marc Handalian [email protected]

Description

Fix IndexShardTests.testRestoreShardFromRemoteStore on Windows.

Windows has buggy File delete logic where AccessDeniedExceptions are thrown when there is an open file handle on a particular file. FSDirectory attempts to resolve this with hacks by swallowing the exceptions and moving the file to a pending delete state to retry in the future while being filtered from listAll invocations.
However, this logic is also buggy and after the first delete attempt we are left in a state where the file is still on disk and not pending delete. This is because FSDirectory#maybeDeletePendingFiles will execute and attempt to delete the purged files again, which hits a NoSuchFileException that is also swallowed.
A second attempt to delete the file will properly move it to pending deletion, and be filtered from listAll.

Issues Resolved

related #1448
closes #5209

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/7409/
• CommitID: fb403b6

[codecov-commenter]

Codecov Report

Merging #5399 (fb403b6) into main (e3fd49f) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #5399      +/-   ##
============================================
+ Coverage     70.88%   70.97%   +0.09%     
- Complexity    58062    58101      +39     
============================================
  Files          4711     4711              
  Lines        277533   277534       +1     
  Branches      40169    40169              
============================================
+ Hits         196737   196993     +256     
+ Misses        64612    64385     -227     
+ Partials      16184    16156      -28     

Impacted Files	Coverage Δ
server/src/main/java/org/opensearch/Version.java	77.77% <100.00%> (+0.10%)	⬆️
...g/opensearch/index/analysis/CharFilterFactory.java	0.00% <0.00%> (-100.00%)	⬇️
.../java/org/opensearch/node/NodeClosedException.java	50.00% <0.00%> (-50.00%)	⬇️
.../java/org/opensearch/search/dfs/AggregatedDfs.java	51.61% <0.00%> (-41.94%)	⬇️
...ava/org/opensearch/search/dfs/DfsSearchResult.java	47.87% <0.00%> (-39.37%)	⬇️
...h/action/ingest/SimulateDocumentVerboseResult.java	60.71% <0.00%> (-39.29%)	⬇️
...tions/InternalSingleBucketAggregationTestCase.java	59.74% <0.00%> (-36.37%)	⬇️
...n/decider/SnapshotInProgressAllocationDecider.java	34.78% <0.00%> (-34.79%)	⬇️
...arch/search/aggregations/pipeline/LinearModel.java	23.07% <0.00%> (-34.62%)	⬇️
...r/src/main/java/org/opensearch/http/HttpUtils.java	33.33% <0.00%> (-33.34%)	⬇️
... and 495 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.