-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Windows CI on pull requests #1448
Comments
How much of the tests is precommit running? For example, will tests in #4656 be exercised in CI with the change, or did we close this prematurely? |
@dblock thats a good point. Precommit only runs few basic checks but does not run unit/integ tests. Thinking about next steps, I am worried if we do have multiple gradle checks (linux, windows) the chances of failure multiplies (unfortunately due to flaky tests). How about splitting platform specific tests and only run them on windows/macos etc instead of running the whole suite ? |
AFAIK the majority of flakey tests are integration and it's a separate (albeit important) problem. I believe there's a set of unit tests that never fails and we should start with that and keep increasing coverage. Starting with platform-specific tests is a good idea, I would gladly merge just that! |
I've spent sometime yesterday was able to run
|
I was able to get past the problem of permissions. Looks like we have to run as a non-root user.
|
Got past the problems with bwc now hitting problems with Java mmap.
|
Hi, @dblock @saratvemulapalli could you guys let me know what is the reason that Gradle Check is needed for Windows? I believe the windows ci should be the building process on Windows, which we can then use github actions to achieve, not gradle check. Please feel free to let me know but this requires a lot of effort just to setup the runner. Thanks. |
We need to plan this from our side if we bound to add windows gradle check. |
Also, |
@peterzhuamazon we cannot release software which we dont test. |
Got it. Lets talk a bit more on the requirements. The thing I am more concerning is the windows runner takes 2x time to complete gradle check compares to linux host. |
Just talked with @saratvemulapalli and @Poojita-Raj and here are the steps on high level:
|
Hi,
|
Facing the below errors. `1: Task failed with an exception.
2: Task failed with an exception.
3: Task failed with an exception.
4: Task failed with an exception.
BUILD FAILED in 17m 40s |
Build Tools, integTest is failing. Tests look very platform specific.
|
Finally I was able to run gradle check with 2+ hrs of runtime
|
Below failures comes after 96%+ build of gradle check. I have made some modifications regarding commenting code of every possible test case running on any other OS except windows.
|
For this specific issue, we want some windows CI on GHA that runs on every PR. The complete gradle check with all integration tests is another ask. |
TEST Failing while othe platforms code commented.
Test failure errors:
Test failure errors:
same errors and failure as above test
same errors and failure as above test
same errors and failure as above test
same errors and failure as above test
same errors and failures as above test
same errors and failures as above test CustomSuggesterClientYamlTestSuiteIT. classMethod |
Need to backport changes needed for windows CI to run to both 1.x and 1.3 branch. These are all the changes that have taken place -
|
@Poojita-Raj Is there an effort to get OpenSearch 1.3 working on Windows? As far as I know, support for Windows in only for OpenSearch 2.4+ |
Hi, just want to make sure this issue is closed, if all the tasks are completed. Thanks. |
Related issue is #1975. If we break up |
Added the following tasks still remaining.
|
1.x: https://build.ci.opensearch.org/job/gradle-check/7060/ |
@mch2 @peterzhuamazon @Poojita-Raj @minalsha So what do we need to close this issue out with confidence? |
This issue specifically is around a PR gate on windows, we have additional work required to get on-merge/nightlies to green. The question is what to run and where. What to run? Where to run?
|
@mch2 what is needed to close this issue? Is it following pending workitems in the issue description? |
@minalsha yes, I just cleaned up the issue description. The first step is getting stability in our nightly runs both from jenkins & the check and trigger them from GH. Then we will be able to transition to on PR checks. The previous issues we had about running a subset on GH i've closed as not enough of the gradle tasks would succeed to be worthwhile. |
Is your feature request related to a problem? Please describe.
Coming from opensearch-project/opensearch-build#33
Gradle Check running on Windows (Failures so far)
Describe the solution you'd like
Add Windows CI for this repo at least for the minimum gradle precommit.
The text was updated successfully, but these errors were encountered: