Merge first batch of feature/extensions into main

[ryanbogan]

Signed-off-by: Ryan Bogan [email protected]

Description

This PR merges the first batch of feature/extensions into main and will then be backported to 2.x.

Issues Resolved

Issue with links to PR's included in this merge: #5264
Meta issue for entire feature/extensions merge: #5263

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/7243/
• CommitID: 072318f

[codecov-commenter]

Codecov Report

Merging #5347 (def10fa) into main (67977a2) will decrease coverage by 0.08%.
The diff coverage is 56.75%.

@@             Coverage Diff              @@
##               main    #5347      +/-   ##
============================================
- Coverage     71.08%   70.99%   -0.09%     
- Complexity    58259    58271      +12     
============================================
  Files          4718     4730      +12     
  Lines        277697   278164     +467     
  Branches      40195    40226      +31     
============================================
+ Hits         197399   197490      +91     
- Misses        64181    64509     +328     
- Partials      16117    16165      +48     

Impacted Files	Coverage Δ
...tion/admin/cluster/state/ClusterStateResponse.java	80.00% <0.00%> (-2.36%)	⬇️
...c/main/java/org/opensearch/bootstrap/Security.java	32.63% <0.00%> (-0.46%)	⬇️
...n/java/org/opensearch/discovery/PluginRequest.java	0.00% <0.00%> (ø)
.../java/org/opensearch/discovery/PluginResponse.java	0.00% <0.00%> (ø)
...ava/org/opensearch/index/AcknowledgedResponse.java	0.00% <0.00%> (ø)
...va/org/opensearch/index/IndicesModuleResponse.java	0.00% <0.00%> (ø)
...ava/org/opensearch/index/IndicesModuleRequest.java	18.18% <18.18%> (ø)
...rg/opensearch/cluster/ClusterSettingsResponse.java	21.42% <21.42%> (ø)
...java/org/opensearch/cluster/LocalNodeResponse.java	21.42% <21.42%> (ø)
...va/org/opensearch/extensions/ExtensionRequest.java	29.41% <29.41%> (ø)
... and 487 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/7245/
• CommitID: bdd4b58

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/7246/
• CommitID: 21355f1

[dblock]

Glad to see this coming!

I have a bunch of nitpicky comments on naming. I think we should try and get those right since it's all brand new.

I'd like this to come with some .md content in developer guide or somewhere else.

@reta would love your comments

[ryanbogan]

@dblock DEVELOPER_GUIDE.md on opensearch-sdk-java contains all of the instructions for using extensions, although it will have to be modified with publishing the main branch to mavenLocal and enabling the feature flag.

Here's the file:
https://github.com/opensearch-project/opensearch-sdk-java/blob/main/DEVELOPER_GUIDE.md

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/7288/
• CommitID: 2f1a588
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[reta]

@ryanbogan could you please rebase against main? it seems like there are a lot of unrelated changes, thank you

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/7344/
• CommitID: 2912b8c
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/7875/
• CommitID: c4643c3

[ryanbogan]

@reta just need your review and then we can merge or make changes as necessary

[reta]

@reta just need your review and then we can merge or make changes as necessary

I have only concerns regarding this pattern we use in several places

                                /*
                                 * Making async synchronous for now.
                                 */
                                inProgressIndexNameFuture.get(100, TimeUnit.SECONDS);

Otherwise LGTM (if you prefer to merge like this, we could address that later by chaining futures instead), thanks!

[ryanbogan]

@reta just need your review and then we can merge or make changes as necessary

I have only concerns regarding this pattern we use in several places

                                /*
                                 * Making async synchronous for now.
                                 */
                                inProgressIndexNameFuture.get(100, TimeUnit.SECONDS);

Otherwise LGTM (if you prefer to merge like this, we could address that later by chaining futures instead), thanks!

There are more latches coming in the next few PR's, so let's address that more thoroughly then.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/7884/
• CommitID: a5a1aff
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[saratvemulapalli]

@reta just need your review and then we can merge or make changes as necessary

I have only concerns regarding this pattern we use in several places

                                /*
                                 * Making async synchronous for now.
                                 */
                                inProgressIndexNameFuture.get(100, TimeUnit.SECONDS);

Otherwise LGTM (if you prefer to merge like this, we could address that later by chaining futures instead), thanks!

Yeah this is because we had to keep the extension points waiting as they are synchronous today.
@ryanbogan lets open up an issue for all the latches we use and we should move each extension point to have hooks(async).
@reta if you have thoughts on this problem let us know.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/7888/
• CommitID: def10fa

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-5347-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e41cbe52134488ab29dcf6276dc2fea65c7f5105
# Push it to GitHub
git push --set-upstream origin backport/backport-5347-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-5347-to-2.x.