Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bwc for cluster manager throttling settings #5305

Merged
merged 1 commit into from
Dec 6, 2022
Merged

Fix bwc for cluster manager throttling settings #5305

merged 1 commit into from
Dec 6, 2022

Conversation

dhwanilpatel
Copy link
Contributor

Signed-off-by: Dhwanil Patel [email protected]

Description

Fix bwc test failure for plugins due to cluster manager throttling setting.

Issues Resolved

Relates #5287

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@dhwanilpatel dhwanilpatel marked this pull request as ready for review November 18, 2022 13:01
@dhwanilpatel dhwanilpatel requested review from a team and reta as code owners November 18, 2022 13:01
Bukhtawar
Bukhtawar reviewed Nov 18, 2022
View reviewed changes
server/src/main/java/org/opensearch/cluster/service/ClusterManagerTaskThrottler.java
Map<String, Settings> groups = settings.getAsGroups();
if (groups.size() > 0) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my understanding what does this validate?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This validateSetting method gets invoked every time even when this setting is not changed.

When other settings get changes this validate method gets called with empty settings. So that's why added check to avoid version check when called with empty setting.

Since this is group setting, if it is empty setting, it's size will be zero.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When other settings get changes this validate method gets called with empty settings. So that's why added check to avoid version check when called with empty setting.

@dhwanilpatel can you point to code where this happens?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need to go through the code to find out the pointers, I have seen this behavior in local testing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the code reference where it validates setting against all settings before applying it.

Code ref: https://github.com/opensearch-project/OpenSearch/blob/main/server/src/main/java/org/opensearch/common/settings/AbstractScopedSettings.java#L167-L188

@jmazanec15
Copy link
Member

@dhwanilpatel @Bukhtawar Is this ready to be merged? If not, can we revert the change instead of fix to unblock our CI for k-NN

@jmazanec15 jmazanec15 mentioned this pull request Dec 5, 2022
Closed
@Bukhtawar Bukhtawar merged commit 913cb3a into opensearch-project:main Dec 6, 2022
@dhwanilpatel dhwanilpatel mentioned this pull request Dec 6, 2022
Merged
6 tasks
ryanbogan pushed a commit that referenced this pull request Dec 13, 2022
@dhwanilpatel @ryanbogan
Fix bwc for cluster manager throttling settings (#5305)
0f3cb7a 
Signed-off-by: Dhwanil Patel <[email protected]>
ryanbogan pushed a commit to ryanbogan/OpenSearch that referenced this pull request Dec 13, 2022
@dhwanilpatel @ryanbogan
Fix bwc for cluster manager throttling settings (opensearch-project#5305
ccabf8c 
)

Signed-off-by: Dhwanil Patel <[email protected]>
saratvemulapalli pushed a commit that referenced this pull request Dec 13, 2022
@ryanbogan @dhwanilpatel
[Feature/extensions] Update settings registration changes to reflect …
bde8317 
…main (#5532)

* Update settings changes to reflect main

Signed-off-by: Ryan Bogan <[email protected]>

* Update CHANGELOG

Signed-off-by: Ryan Bogan <[email protected]>

* Fix bwc for cluster manager throttling settings (#5305)

Signed-off-by: Dhwanil Patel <[email protected]>

Signed-off-by: Ryan Bogan <[email protected]>
Signed-off-by: Dhwanil Patel <[email protected]>
Co-authored-by: Dhwanil Patel <[email protected]>
saratvemulapalli pushed a commit that referenced this pull request Dec 15, 2022
@cwperks @Rishikesh1159
@dhwanilpatel @reta @ashking94 @nknize @rursprung @dblock @ryanbogan @Poojita-Raj @xuezhou25 @mch2 @dependabot @owaiskazi19 @imRishN @dreamer-89 @noCharger @opensearch-ci-bot @zelinh
[Feature/Identity] Merge remote-tracking branch 'origin/main' into fe…
8dd63a5 
…ature/identity (#5581)

* Fix flaky ShardIndexingPressureConcurrentExecutionTests (#5439)

Add conditional check on assertNull to fix flaky tests.

Signed-off-by: Rishikesh1159 <[email protected]>

* Fix bwc for cluster manager throttling settings (#5305)

Signed-off-by: Dhwanil Patel <[email protected]>

* Update ingest-attachment plugin dependencies: Apache Tika 3.6.0, Apache Mime4j 0.8.8, Apache Poi 5.2.3, Apache PdfBox 2.0.27 (#5448)

Signed-off-by: Andriy Redko <[email protected]>

Signed-off-by: Andriy Redko <[email protected]>

* Enhance CheckpointState to support no-op replication (#5282)

* CheckpointState enhanced to support no-op replication

Signed-off-by: Ashish Singh <[email protected]>
Co-authored-by: Bukhtawar Khan<[email protected]>

* [BUG] org.opensearch.repositories.s3.RepositoryS3ClientYamlTestSuiteIT/test {yaml=repository_s3/20_repository_permanent_credentials/Snapshot and Restore with repository-s3 using permanent credentials} flaky: randomizing basePath (#5482)

Signed-off-by: Andriy Redko <[email protected]>

Signed-off-by: Andriy Redko <[email protected]>

* [Bug] fix case sensitivity for wildcard queries (#5462)

Fixes the wildcard query to not normalize the pattern when case_insensitive is
set by the user. This is achieved by creating a new normalizedWildcardQuery
method so that query_string queries (which do not support case sensitivity) can
still normalize the pattern when the default analyzer is used; maintaining
existing behavior.

Signed-off-by: Nicholas Walter Knize <[email protected]>

* Support OpenSSL Provider with default Netty allocator (#5460)

Signed-off-by: Andriy Redko <[email protected]>

Signed-off-by: Andriy Redko <[email protected]>

* Revert "build no-jdk distributions as part of release build (#4902)" (#5465)

This reverts commit 8c9ca4e.

It seems that this wasn't entirely the correct way and is currently
blocking us from removing the `build.sh` from the `opensearch-build`
repository (i.e. this `build.sh` here is not yet being used).
See the discussion in opensearch-project/opensearch-build#2835 for
further details.

Signed-off-by: Ralph Ursprung <[email protected]>

Signed-off-by: Ralph Ursprung <[email protected]>

* Add max_shard_size parameter for Shrink API (fix supported version after backport) (#5503)

Signed-off-by: Andriy Redko <[email protected]>

Signed-off-by: Andriy Redko <[email protected]>

* Sync CODEOWNERS with MAINTAINERS. (#5501)

Signed-off-by: Daniel (dB.) Doubrovkine <[email protected]>

Signed-off-by: Daniel (dB.) Doubrovkine <[email protected]>

* Added jackson dependency to server (#5366)

* Added jackson dependency to server

Signed-off-by: Ryan Bogan <[email protected]>

* Updated CHANGELOG

Signed-off-by: Ryan Bogan <[email protected]>

* Update build.gradle files

Signed-off-by: Ryan Bogan <[email protected]>

* Add RuntimePermission to fix errors

Signed-off-by: Ryan Bogan <[email protected]>

Signed-off-by: Ryan Bogan <[email protected]>

* Fix flaky test BulkIntegrationIT.testDeleteIndexWhileIndexing (#5491)

Signed-off-by: Poojita Raj <[email protected]>

Signed-off-by: Poojita Raj <[email protected]>

* Add release notes for 2.4.1 (#5488)

Signed-off-by: Xue Zhou <[email protected]>

Signed-off-by: Xue Zhou <[email protected]>

* Properly skip OnDemandBlockSnapshotIndexInputTests.testVariousBlockSize on Windows. (#5511)

PR #5397 skipped this test in @before block but still
frequently throws a TestCouldNotBeSkippedException.  This is caused by the after block still executing and throwing  an exception
while cleaning the directory created at the path in @before.  Moving the assumption to the individual test prevents this exception by ensuring the path exists.

Signed-off-by: Marc Handalian <[email protected]>

Signed-off-by: Marc Handalian <[email protected]>

* Merge first batch of feature/extensions into main (#5347)

* Merge first batch of feature/extensions into main

Signed-off-by: Ryan Bogan <[email protected]>

* Fixed CHANGELOG

Signed-off-by: Ryan Bogan <[email protected]>

* Fixed newline errors

Signed-off-by: Ryan Bogan <[email protected]>

* Renaming and CHANGELOG fixes

Signed-off-by: Ryan Bogan <[email protected]>

* Refactor extension loading into private method

Signed-off-by: Ryan Bogan <[email protected]>

* Removed skipValidation and added connectToExtensionNode method

Signed-off-by: Ryan Bogan <[email protected]>

* Remove unnecessary feature flag calls

Signed-off-by: Ryan Bogan <[email protected]>

* Renaming and exception handling

Signed-off-by: Ryan Bogan <[email protected]>

* Change latches to CompletableFuture

Signed-off-by: Ryan Bogan <[email protected]>

* Removed unnecessary validateSettingKey call

Signed-off-by: Ryan Bogan <[email protected]>

* Fix azure-core dependency

Signed-off-by: Ryan Bogan <[email protected]>

* Update SHAs

Signed-off-by: Ryan Bogan <[email protected]>

* Remove unintended dependency changes

Signed-off-by: Ryan Bogan <[email protected]>

* Removed dynamic settings regitration, removed info() method, and added NoopExtensionsManager

Signed-off-by: Ryan Bogan <[email protected]>

* Add javadoc

Signed-off-by: Ryan Bogan <[email protected]>

* Fixed spotless failure

Signed-off-by: Ryan Bogan <[email protected]>

* Removed NoopExtensionsManager

Signed-off-by: Ryan Bogan <[email protected]>

* Added functioning NoopExtensionsManager

Signed-off-by: Ryan Bogan <[email protected]>

* Added missing javadoc

Signed-off-by: Ryan Bogan <[email protected]>

* Remove forbiddenAPI

Signed-off-by: Ryan Bogan <[email protected]>

* Fix spotless

Signed-off-by: Ryan Bogan <[email protected]>

* Change logger.info to logger.error in handleException

Signed-off-by: Ryan Bogan <[email protected]>

* Fix ExtensionsManagerTests

Signed-off-by: Ryan Bogan <[email protected]>

* Removing unrelated change

Signed-off-by: Ryan Bogan <[email protected]>

* Update SHAs

Signed-off-by: Ryan Bogan <[email protected]>

Signed-off-by: Ryan Bogan <[email protected]>

* Bump commons-compress from 1.21 to 1.22 (#5520)

Bumps commons-compress from 1.21 to 1.22.

---
updated-dependencies:
- dependency-name: org.apache.commons:commons-compress
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* [Segment Replication] Trigger a round of replication for replica shards during peer recovery when segment replication is enabled (#5332)

* Fix new added replica shards falling behind primary.

Signed-off-by: Rishikesh1159 <[email protected]>

* Trigger a round of replication during peer recovery when segment replication is enabled.

Signed-off-by: Rishikesh1159 <[email protected]>

* Remove unnecessary start replication overloaded method.

Signed-off-by: Rishikesh1159 <[email protected]>

* Add test for failure case and refactor some code.

Signed-off-by: Rishikesh1159 <[email protected]>

* Apply spotless check.

Signed-off-by: Rishikesh1159 <[email protected]>

* Addressing comments on the PR.

Signed-off-by: Rishikesh1159 <[email protected]>

* Remove unnecessary condition check.

Signed-off-by: Rishikesh1159 <[email protected]>

* Apply spotless check.

Signed-off-by: Rishikesh1159 <[email protected]>

* Add step listeners to resolve forcing round of segment replication.

Signed-off-by: Rishikesh1159 <[email protected]>

Signed-off-by: Rishikesh1159 <[email protected]>

* Adding support to register settings dynamically (#5495)

* Adding support to register settings dynamically

Signed-off-by: Ryan Bogan <[email protected]>

* Update CHANGELOG

Signed-off-by: Ryan Bogan <[email protected]>

* Removed unnecessary registerSetting methods

Signed-off-by: Ryan Bogan <[email protected]>

* Change setting registration order

Signed-off-by: Ryan Bogan <[email protected]>

* Add unregisterSettings method

Signed-off-by: Ryan Bogan <[email protected]>

* Remove unnecessary feature flag

Signed-off-by: Ryan Bogan <[email protected]>

Signed-off-by: Ryan Bogan <[email protected]>

* Updated 1.3.7 release notes date (#5536)

Signed-off-by: owaiskazi19 <[email protected]>

Signed-off-by: owaiskazi19 <[email protected]>

* Pre conditions check before updating weighted routing metadata (#4955)

* Pre conditions check to allow weight updates for non decommissioned attribute

Signed-off-by: Rishab Nahata <[email protected]>

* Atomically update cluster state with decommission status and corresponding action (#5093)

* Atomically update the cluster state with decommission status and its corresponding action in the same execute call

Signed-off-by: Rishab Nahata <[email protected]>

* Update Netty to 4.1.86.Final (#5529)

Signed-off-by: Andriy Redko <[email protected]>

Signed-off-by: Andriy Redko <[email protected]>

* Update release date in 2.4.1 release notes (#5549)

Signed-off-by: Suraj Singh <[email protected]>

Signed-off-by: Suraj Singh <[email protected]>

* Update 2.4.1 release notes (#5552)

Signed-off-by: Andriy Redko <[email protected]>

Signed-off-by: Andriy Redko <[email protected]>

* Refactor fuzziness interface on query builders (#5433)

* Refactor Object to Fuzziness type for all query builders

Signed-off-by: noCharger <[email protected]>

* Revise on bwc

Signed-off-by: noCharger <[email protected]>

* Update change log

Signed-off-by: noCharger <[email protected]>

Signed-off-by: noCharger <[email protected]>
Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]>

* Upgrade lucene version (#5570)

* Added bwc version 2.4.2

Signed-off-by: Daniel (dB.) Doubrovkine <[email protected]>

* Added 2.4.2.

Signed-off-by: Daniel (dB.) Doubrovkine <[email protected]>

* Update Lucene snapshot to 9.5.0-snapshot-d5cef1c

Signed-off-by: Suraj Singh <[email protected]>

* Update changelog entry

Signed-off-by: Suraj Singh <[email protected]>

* Add 2.4.2 bwc version

Signed-off-by: Suraj Singh <[email protected]>

* Internal changes post lucene upgrade

Signed-off-by: Suraj Singh <[email protected]>

Signed-off-by: Daniel (dB.) Doubrovkine <[email protected]>
Signed-off-by: Suraj Singh <[email protected]>
Co-authored-by: opensearch-ci-bot <[email protected]>
Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]>

* Add CI bundle pattern to distribution download (#5348)

* Add CI bundle pattern for ivy repo

Signed-off-by: Zelin Hao <[email protected]>

* Gradle update

Signed-off-by: Zelin Hao <[email protected]>

* Extract path

Signed-off-by: Zelin Hao <[email protected]>

* Change with customDistributionDownloadType

Signed-off-by: Zelin Hao <[email protected]>

* Add default for exception handle

Signed-off-by: Zelin Hao <[email protected]>

* Add documentations

Signed-off-by: Zelin Hao <[email protected]>

Signed-off-by: Zelin Hao <[email protected]>

* Bump protobuf-java from 3.21.9 to 3.21.11 in /plugins/repository-hdfs (#5519)

* Bump protobuf-java from 3.21.9 to 3.21.11 in /plugins/repository-hdfs

Bumps [protobuf-java](https://github.com/protocolbuffers/protobuf) from 3.21.9 to 3.21.11.
- [Release notes](https://github.com/protocolbuffers/protobuf/releases)
- [Changelog](https://github.com/protocolbuffers/protobuf/blob/main/generate_changelog.py)
- [Commits](protocolbuffers/protobuf@v3.21.9...v3.21.11)

---
updated-dependencies:
- dependency-name: com.google.protobuf:protobuf-java
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Updating SHAs

Signed-off-by: dependabot[bot] <[email protected]>

* Updated changelog

Signed-off-by: Owais Kazi <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Co-authored-by: Owais Kazi <[email protected]>
Co-authored-by: Suraj Singh <[email protected]>

Signed-off-by: Rishikesh1159 <[email protected]>
Signed-off-by: Dhwanil Patel <[email protected]>
Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: Ashish Singh <[email protected]>
Signed-off-by: Nicholas Walter Knize <[email protected]>
Signed-off-by: Ralph Ursprung <[email protected]>
Signed-off-by: Daniel (dB.) Doubrovkine <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
Signed-off-by: Poojita Raj <[email protected]>
Signed-off-by: Xue Zhou <[email protected]>
Signed-off-by: Marc Handalian <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: owaiskazi19 <[email protected]>
Signed-off-by: Rishab Nahata <[email protected]>
Signed-off-by: Suraj Singh <[email protected]>
Signed-off-by: noCharger <[email protected]>
Signed-off-by: Zelin Hao <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
Co-authored-by: Rishikesh Pasham <[email protected]>
Co-authored-by: Dhwanil Patel <[email protected]>
Co-authored-by: Andriy Redko <[email protected]>
Co-authored-by: Ashish <[email protected]>
Co-authored-by: Nick Knize <[email protected]>
Co-authored-by: Ralph Ursprung <[email protected]>
Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]>
Co-authored-by: Ryan Bogan <[email protected]>
Co-authored-by: Poojita Raj <[email protected]>
Co-authored-by: Xue Zhou <[email protected]>
Co-authored-by: Marc Handalian <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Owais Kazi <[email protected]>
Co-authored-by: Rishab Nahata <[email protected]>
Co-authored-by: Suraj Singh <[email protected]>
Co-authored-by: Louis Chu <[email protected]>
Co-authored-by: opensearch-ci-bot <[email protected]>
Co-authored-by: Zelin Hao <[email protected]>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmazanec15 jmazanec15 jmazanec15 left review comments

@Bukhtawar Bukhtawar Bukhtawar approved these changes

@reta reta Awaiting requested review from reta reta is a code owner

Assignees
No one assigned
Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dhwanilpatel @jmazanec15 @Bukhtawar @adnapibar