Fix weighted routing metadata deserialization error during node restart

[anshu1106]

Signed-off-by: Anshu Agarwal [email protected]

Description

Deserialization of weighted routing metadata is failing during node restart. This PR fixes the serialization error

Issues Resolved

#4690

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/3912/
• CommitID: 65afaba

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/3956/
• CommitID: 522dd10

[Bukhtawar]

Please lets add tests here

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/4091/
• CommitID: 9e22066

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/4096/
• CommitID: 9025518

[imRishN]

LGTM, thanks @anshu1106

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/4100/
• CommitID: 636afab

[anshu1106]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/4100/
• CommitID: 636afab

Build is unstable due to unrelated test failures. Building again

[Test Result](https://build.ci.opensearch.org/job/gradle-check/4100/testReport/) (3 failures / +3)
[org.opensearch.action.admin.indices.create.CreateIndexIT.testCreateAndDeleteIndexConcurrently](https://build.ci.opensearch.org/job/gradle-check/4100/testReport/junit/org.opensearch.action.admin.indices.create/CreateIndexIT/testCreateAndDeleteIndexConcurrently/)
[org.opensearch.action.admin.indices.create.CreateIndexIT.classMethod](https://build.ci.opensearch.org/job/gradle-check/4100/testReport/junit/org.opensearch.action.admin.indices.create/CreateIndexIT/classMethod/)
[org.opensearch.indices.stats.IndexStatsIT.testFilterCacheStats](https://build.ci.opensearch.org/job/gradle-check/4100/testReport/junit/org.opensearch.indices.stats/IndexStatsIT/testFilterCacheStats/)

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/4104/
• CommitID: cc83386

[codecov-commenter]

Codecov Report

Merging #4691 (5b6d792) into main (7c03f89) will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #4691      +/-   ##
============================================
+ Coverage     70.71%   70.73%   +0.02%     
- Complexity    57569    57599      +30     
============================================
  Files          4660     4660              
  Lines        276601   276600       -1     
  Branches      40307    40307              
============================================
+ Hits         195596   195660      +64     
+ Misses        64771    64696      -75     
- Partials      16234    16244      +10     

Impacted Files	Coverage Δ
...arch/cluster/metadata/WeightedRoutingMetadata.java	61.40% <ø> (+1.05%)	⬆️
...search/indices/recovery/RecoveryTargetHandler.java	0.00% <0.00%> (-100.00%)	⬇️
.../java/org/opensearch/node/NodeClosedException.java	50.00% <0.00%> (-50.00%)	⬇️
.../index/shard/IndexShardNotRecoveringException.java	50.00% <0.00%> (-50.00%)	⬇️
.../admin/cluster/reroute/ClusterRerouteResponse.java	60.00% <0.00%> (-40.00%)	⬇️
...luster/routing/allocation/RoutingExplanations.java	62.06% <0.00%> (-37.94%)	⬇️
...java/org/opensearch/threadpool/ThreadPoolInfo.java	56.25% <0.00%> (-37.50%)	⬇️
...ensearch/client/indices/DetailAnalyzeResponse.java	20.54% <0.00%> (-34.25%)	⬇️
...cluster/routing/allocation/RerouteExplanation.java	70.00% <0.00%> (-30.00%)	⬇️
...org/opensearch/test/engine/MockInternalEngine.java	56.52% <0.00%> (-26.09%)	⬇️
... and 488 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[nknize]

thx!

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/4469/
• CommitID: 5b6d792