Delete API for weighted round robin search routing #4400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gradle Check (Jenkins) Run Completed with:
|
gbbafna
reviewed
Sep 5, 2022
server/src/internalClusterTest/java/org/opensearch/search/SearchWRRIT.java
Outdated
Show resolved
Hide resolved
server/src/internalClusterTest/java/org/opensearch/search/SearchWRRIT.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| } | ||
|
|
There was a problem hiding this comment.
should we remove the weights and then assert again that requests are equally distributed ?
There was a problem hiding this comment.
Sure, any pointers on which stat I can assert on for request distribution?
There was a problem hiding this comment.
sorry missed this. You can look for node/stats API call for this.
| * | ||
| * @opensearch.internal | ||
| */ | ||
| public class TransportGetWRRWeightsAction extends TransportClusterManagerNodeReadAction< |
There was a problem hiding this comment.
should we extend HandledTransportAction instead of TransportClusterManagerNodeReadAction ? I do see that TransportClusterManagerNodeReadAction are used for GET actions which needs cluster state . but just thinking about the benefits/cost for the same .
...org/opensearch/action/admin/cluster/shards/routing/wrr/get/TransportGetWRRWeightsAction.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/client/ClusterAdminClient.java
Outdated
Show resolved
Hide resolved
5 tasks
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
anshu1106
force-pushed
the
feature/wrr-delete-api
branch
from
7b37962 to
7a8a4d2
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
20 tasks
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #4400 +/- ##
============================================
+ Coverage 70.66% 70.78% +0.12%
- Complexity 57578 57698 +120
============================================
Files 4661 4675 +14
Lines 276662 276918 +256
Branches 40325 40347 +22
============================================
+ Hits 195501 196016 +515
+ Misses 64926 64684 -242
+ Partials 16235 16218 -17
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
anshu1106
force-pushed
the
feature/wrr-delete-api
branch
from
6554f3a to
e864111
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Anshu Agarwal <[email protected]>
anshu1106
force-pushed
the
feature/wrr-delete-api
branch
from
e864111 to
56fe6af
Compare
imRishN
suggested changes
Oct 6, 2022
Comment on lines
86
to
89
| ActionListener.delegateFailure( | ||
| listener, | ||
| (delegatedListener, response) -> { | ||
| delegatedListener.onResponse(new ClusterDeleteWeightedRoutingResponse(response.isAcknowledged())); |
There was a problem hiding this comment.
Why do we need to delegate this? The service method definition can be changed to ClusterDeleteWRResponse?
There was a problem hiding this comment.
Removed delegatedListener
Comment on lines
+117
to
+120
| logger.info("Deleting weighted routing metadata from the cluster state"); | ||
| Metadata.Builder mdBuilder = Metadata.builder(currentState.metadata()); | ||
| mdBuilder.removeCustom(WeightedRoutingMetadata.TYPE); | ||
| return ClusterState.builder(currentState).metadata(mdBuilder).build(); |
There was a problem hiding this comment.
If we just wipe off the metadata will it internally handle to use ARS strategy? Or what will happen to subsequent requests?
There was a problem hiding this comment.
Yeah, subsequent requests will use ARS or attribute based routing. For multi-az clusters, currently ARS is not supported.
|
|
||
| @Override | ||
| public void onFailure(String source, Exception e) { | ||
| logger.warn(() -> new ParameterizedMessage("failed to remove weighted routing metadata from cluster state [{}]", e)); |
There was a problem hiding this comment.
nit: the msg looks like is exoecting a cluster state but provided an exception.
We can make this logger.error and pass the exception in it
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Anshu Agarwal <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Anshu Agarwal <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
imRishN
reviewed
Oct 6, 2022
Comment on lines
126
to
131
| logger.error( | ||
| () -> new ParameterizedMessage( | ||
| "failed to remove weighted routing metadata from cluster state with an exception [{}]", | ||
| e | ||
| ) | ||
| ); |
There was a problem hiding this comment.
if there's no other parameter we can keep it like - logger.error(msg, e)
Gradle Check (Jenkins) Run Completed with:
|
anshu1106
force-pushed
the
feature/wrr-delete-api
branch
from
5321b95 to
6a1daad
Compare
Gradle Check (Jenkins) Run Completed with:
|
|
Seeing unrelated test failures |
Signed-off-by: Anshu Agarwal <[email protected]>
anshu1106
force-pushed
the
feature/wrr-delete-api
branch
from
6a1daad to
db8283c
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
imRishN
approved these changes
Oct 7, 2022
Bukhtawar
reviewed
Oct 12, 2022
Comment on lines
+36
to
+39
| @Override | ||
| public List<Route> routes() { | ||
| return singletonList(new Route(DELETE, "/_cluster/routing/awareness/weights")); | ||
| } |
There was a problem hiding this comment.
do we want to support explicit attribute deletion?
There was a problem hiding this comment.
yeah, but this will require few changes in the way data is persisted in cluster state as well. Create an issue to work on this #4747
Gradle Check (Jenkins) Run Completed with:
|
Bukhtawar
approved these changes
Oct 13, 2022
anshu1106
added a commit
to anshu1106/OpenSearch
that referenced
this pull request
Nov 1, 2022
…t#4400) * Delete API for weighted round robin search routing Signed-off-by: Anshu Agarwal <[email protected]>
6 tasks
anshu1106
added a commit
to anshu1106/OpenSearch
that referenced
this pull request
Nov 3, 2022
…t#4400) * Delete API for weighted round robin search routing Signed-off-by: Anshu Agarwal <[email protected]>
6 tasks
Bukhtawar
pushed a commit
that referenced
this pull request
Nov 3, 2022
* Weighted round-robin scheduling policy for shard coordination traffic… (#4241) * Add PUT api to update shard routing weights (#4272) * Add GET api to get shard routing weights (#4275) * Fix weighted routing metadata deserialization error during node restart (#4691) * Delete API for weighted round robin search routing (#4400) * Mark apis experimental Signed-off-by: Anshu Agarwal <[email protected]>
ashking94
pushed a commit
to ashking94/OpenSearch
that referenced
this pull request
Nov 7, 2022
…t#4400) * Delete API for weighted round robin search routing Signed-off-by: Anshu Agarwal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds DELTE api to delete weights for weighted routing policy. This in turn disable the deature.
Issues Resolved
2859
3639
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.