Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup branch push coverage and fix coverage uploads #3793

Merged
merged 1 commit into from
Jul 7, 2022
Merged

Setup branch push coverage and fix coverage uploads #3793

merged 1 commit into from
Jul 7, 2022

Conversation

peterzhuamazon
Copy link
Member

Signed-off-by: Peter Zhu [email protected]

Description

Setup branch push coverage and fix coverage uploads

Issues Resolved

opensearch-project/opensearch-build#2193

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@peterzhuamazon peterzhuamazon added backport 1.x backport 2.x Backport to 2.x branch backport 2.0 Backport to 2.0 branch backport 1.3 Backport to 1.3 branch backport 2.1 labels Jul 7, 2022
@peterzhuamazon peterzhuamazon requested a review from a team as a code owner July 7, 2022 00:25
@peterzhuamazon peterzhuamazon self-assigned this Jul 7, 2022
@peterzhuamazon peterzhuamazon requested a review from reta as a code owner July 7, 2022 00:25
@peterzhuamazon peterzhuamazon added the bug Something isn't working label Jul 7, 2022
This was referenced Jul 7, 2022
Closed
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2022

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2022

Gradle Check (Jenkins) Run Completed with:

dreamer-89
dreamer-89 approved these changes Jul 7, 2022
View reviewed changes
Copy link
Member

@dreamer-89 dreamer-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

.github/workflows/gradle-check.yml Show resolved Hide resolved
.github/workflows/gradle-check.yml Show resolved Hide resolved
.github/workflows/gradle-check.yml Show resolved Hide resolved
@peterzhuamazon
Copy link
Member Author

Note: we still need to test a bit more on this.
As codecov requires the base branch to have codecov 1st before it can compare for analysis.
We might need more changes before this is fully ready.

Thanks.

@peterzhuamazon peterzhuamazon removed backport 1.x backport 2.x Backport to 2.x branch backport 2.0 Backport to 2.0 branch backport 1.3 Backport to 1.3 branch backport 2.1 labels Jul 7, 2022
@peterzhuamazon peterzhuamazon merged commit 7f50513 into opensearch-project:main Jul 7, 2022
@peterzhuamazon peterzhuamazon deleted the opensearch-coverage-fix2 branch July 7, 2022 18:40
@peterzhuamazon peterzhuamazon added backport 1.x backport 2.x Backport to 2.x branch backport 2.0 Backport to 2.0 branch backport 1.3 Backport to 1.3 branch labels Jul 7, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 7, 2022
@peterzhuamazon @github-actions
Setup branch push coverage and fix coverage uploads (#3793)
8ca05ea 
Signed-off-by: Peter Zhu <[email protected]>
(cherry picked from commit 7f50513)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jul 7, 2022
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 7, 2022
@peterzhuamazon @github-actions
Setup branch push coverage and fix coverage uploads (#3793)
4d19429 
Signed-off-by: Peter Zhu <[email protected]>
(cherry picked from commit 7f50513)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jul 7, 2022
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 7, 2022
@peterzhuamazon @github-actions
Setup branch push coverage and fix coverage uploads (#3793)
f97a3f6 
Signed-off-by: Peter Zhu <[email protected]>
(cherry picked from commit 7f50513)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jul 7, 2022
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 7, 2022
@peterzhuamazon @github-actions
Setup branch push coverage and fix coverage uploads (#3793)
c5f6807 
Signed-off-by: Peter Zhu <[email protected]>
(cherry picked from commit 7f50513)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jul 7, 2022
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 7, 2022
@peterzhuamazon @github-actions
Setup branch push coverage and fix coverage uploads (#3793)
331a6e3 
Signed-off-by: Peter Zhu <[email protected]>
(cherry picked from commit 7f50513)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jul 7, 2022
Merged
peterzhuamazon added a commit that referenced this pull request Jul 7, 2022
@opensearch-trigger-bot @peterzhuamazon
Setup branch push coverage and fix coverage uploads (#3793) (#3811)
fa5d195 
Signed-off-by: Peter Zhu <[email protected]>
(cherry picked from commit 7f50513)

Co-authored-by: Peter Zhu <[email protected]>
peterzhuamazon added a commit that referenced this pull request Jul 7, 2022
@opensearch-trigger-bot @peterzhuamazon
Setup branch push coverage and fix coverage uploads (#3793) (#3810)
67f4f05 
Signed-off-by: Peter Zhu <[email protected]>
(cherry picked from commit 7f50513)

Co-authored-by: Peter Zhu <[email protected]>
peterzhuamazon added a commit that referenced this pull request Jul 7, 2022
@opensearch-trigger-bot @peterzhuamazon
Setup branch push coverage and fix coverage uploads (#3793) (#3809)
fb8500a 
Signed-off-by: Peter Zhu <[email protected]>
(cherry picked from commit 7f50513)

Co-authored-by: Peter Zhu <[email protected]>
peterzhuamazon added a commit that referenced this pull request Jul 7, 2022
@opensearch-trigger-bot @peterzhuamazon
Setup branch push coverage and fix coverage uploads (#3793) (#3808)
1a26a6a 
Signed-off-by: Peter Zhu <[email protected]>
(cherry picked from commit 7f50513)

Co-authored-by: Peter Zhu <[email protected]>
peterzhuamazon added a commit that referenced this pull request Jul 7, 2022
@opensearch-trigger-bot @peterzhuamazon
Setup branch push coverage and fix coverage uploads (#3793) (#3812)
b79b0c6 
Signed-off-by: Peter Zhu <[email protected]>
(cherry picked from commit 7f50513)

Co-authored-by: Peter Zhu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreamer-89 dreamer-89 dreamer-89 approved these changes

@CEHENKLE CEHENKLE CEHENKLE approved these changes

@reta reta Awaiting requested review from reta

Assignees

@peterzhuamazon peterzhuamazon

Labels
backport 1.x backport 1.3 Backport to 1.3 branch backport 2.x Backport to 2.x branch backport 2.0 Backport to 2.0 branch backport 2.1 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peterzhuamazon @CEHENKLE @dreamer-89