Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup code coverage for OpenSearch repo #2193

Closed
dreamer-89 opened this issue Jun 14, 2022 · 9 comments
Closed

Setup code coverage for OpenSearch repo #2193

dreamer-89 opened this issue Jun 14, 2022 · 9 comments
Assignees
Labels
enhancement New Enhancement jenkins Jenkins related issue technical-debt Additional rework required to improve the existing code test

Comments

@dreamer-89
Copy link
Member

dreamer-89 commented Jun 14, 2022

Is your feature request related to a problem? Please describe

Setup code coverage for OpenSearch repo.

Describe the solution you'd like

As part of this issue, we need to

  1. Update existing gradle check script to have -Dtests.coverage=true to generate report on CI server. This step generates the report in .xml format under build/codeCoverageReport directory.
  2. Provide mechanism to download/refer generated coverage.xml file on GHA action. This action uploads coverage file on CodeCov server.

Documentation on OpenSearch: https://github.com/opensearch-project/OpenSearch/blob/main/TESTING.md#test-coverage-analysis

Issues on OpenSearch:

  1. Upload code coverage report through CI OpenSearch#1320
  2. Report test coverage OpenSearch#850

Describe alternatives you've considered

No response

Additional context

No response

@dreamer-89 dreamer-89 added enhancement New Enhancement untriaged Issues that have not yet been triaged labels Jun 14, 2022
@dreamer-89 dreamer-89 added test jenkins Jenkins related issue technical-debt Additional rework required to improve the existing code and removed untriaged Issues that have not yet been triaged labels Jun 14, 2022
@gaiksaya
Copy link
Member

Looks like @peterzhuamazon is working on end to end JenkinsFile for gradle check.
@peterzhuamazon can you please update this issue?
Thanks!

@dreamer-89
Copy link
Member Author

@gaiksaya : Thanks for providing the update. Can you please elaborate more on task @peterzhuamazon is working upon. I would like to know more how is it related to the ask on this issue.

@dreamer-89
Copy link
Member Author

dreamer-89 commented Jun 15, 2022

Discussed the ask from infra team with @bbarani. Infra team is currently working on public jenkins migration and will help with this issue post existing gradle check migration to public jenkins by end of next week.

CC @anasalkouz @bbarani

@peterzhuamazon
Copy link
Member

Since we have completed the migration of gradle check in #851 coverage is on the table now.
Will start now.

@peterzhuamazon
Copy link
Member

The coverage results are published to codecov, tho it is not showing the analysis correctly.
Need to sync up with @dreamer-89 on what is the next step.
Seems like the xml itself is the issue.

Thanks.

@peterzhuamazon
Copy link
Member

@peterzhuamazon
Copy link
Member

@peterzhuamazon
Copy link
Member

This task is completed for now close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New Enhancement jenkins Jenkins related issue technical-debt Additional rework required to improve the existing code test
Projects
None yet
Development

No branches or pull requests

3 participants