Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing PluginsServiceTests (post Lucene 9 update) #2484

Merged
merged 1 commit into from
Mar 16, 2022
Merged

Fixing PluginsServiceTests (post Lucene 9 update) #2484

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions server/src/test/java/org/opensearch/plugins/PluginsServiceTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -648,7 +648,6 @@ public void testJarHellTransitiveMap() throws Exception {
assertThat(deps, containsInAnyOrder(pluginJar.toUri().toURL(), dep1Jar.toUri().toURL(), dep2Jar.toUri().toURL()));
}

@AwaitsFix(bugUrl = "https://github.com/opensearch-project/OpenSearch/issues/2063")
public void testNonExtensibleDep() throws Exception {
// This test opens a child classloader, reading a jar under the test temp
// dir (a dummy plugin). Classloaders are closed by GC, so when test teardown
Expand Down Expand Up @@ -791,7 +790,6 @@ public FakePlugin() {

}

@AwaitsFix(bugUrl = "https://github.com/opensearch-project/OpenSearch/issues/2063")
public void testExistingMandatoryInstalledPlugin() throws IOException {
// This test opens a child classloader, reading a jar under the test temp
// dir (a dummy plugin). Classloaders are closed by GC, so when test teardown
Expand Down Expand Up @@ -825,7 +823,6 @@ public void testExistingMandatoryInstalledPlugin() throws IOException {
newPluginsService(settings);
}

@AwaitsFix(bugUrl = "https://github.com/opensearch-project/OpenSearch/issues/2063")
public void testPluginFromParentClassLoader() throws IOException {
final Path pathHome = createTempDir();
final Path plugins = pathHome.resolve("plugins");
Expand Down Expand Up @@ -863,7 +860,6 @@ public void testPluginFromParentClassLoader() throws IOException {
);
}

@AwaitsFix(bugUrl = "https://github.com/opensearch-project/OpenSearch/issues/2063")
public void testPluginLoadFailure() throws IOException {
final Path pathHome = createTempDir();
final Path plugins = pathHome.resolve("plugins");
Expand Down