Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing PluginsServiceTests (post Lucene 9 update) #2484

Merged
merged 1 commit into from
Mar 16, 2022

Conversation

reta
Copy link
Collaborator

@reta reta commented Mar 16, 2022

Signed-off-by: Andriy Redko [email protected]

Description

Fixing PluginsServiceTests

Issues Resolved

Part of #2063

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 6a0606f
Log 3442

Reports 3442

@reta
Copy link
Collaborator Author

reta commented Mar 16, 2022

@nknize I am very confused .... you said tests were failing, with AccessDeniedException right?

@reta reta marked this pull request as ready for review March 16, 2022 14:16
@reta reta requested a review from a team as a code owner March 16, 2022 14:16
@dblock dblock merged commit 77d1060 into opensearch-project:main Mar 16, 2022
@reta reta mentioned this pull request Mar 16, 2022
9 tasks
@nknize
Copy link
Collaborator

nknize commented Mar 16, 2022

you said tests were failing, with AccessDeniedException right?

Yes they did. Twice. I just purged local gradle cache and it passed for me so ¯\_(ツ)_/¯

Looks like we can mark this as done! Thx for following through.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants