Added jenkinsfile to run gradle check in OpenSearch #2166

owaiskazi19 · 2022-02-18T02:35:06Z

Signed-off-by: Owais Kazi [email protected]

Description

Created a new ubuntu docker image for gradle check. Link
Added a jenkinsfile to run gradle check in OpenSearch. After jenkins go public logs will be available in the CI.

Sample run: http://opens-jenki-a7sro6sneahz-2051798054.us-west-2.elb.amazonaws.com/job/Gradle_Check/job/Gradle_Check/4/console

Steps to run the jenkinsfile:

Create a pipeline job with Git as SCM. Add the opensearch repo url to clone, branch as main.
Provide the script path as jenkins/jenkinsfile.

Issues Resolved

Closes #2507

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

opensearch-ci-bot · 2022-02-18T02:36:03Z

Can one of the admins verify this patch?

opensearch-ci-bot · 2022-02-18T03:12:14Z

✅ Gradle Check success b30ca615221dbb8097a6fdb00dff663304ebe693
Log 2553

Reports 2553

opensearch-ci-bot · 2022-02-18T03:15:16Z

✅ Gradle Check success bce0434
Log 2554

Reports 2554

jenkins/gradle-check-assemble.sh

jenkins/post-build-task2.sh

saratvemulapalli · 2022-02-18T20:37:32Z

jenkins/gradle-check-assemble.sh

+docker ps
+docker stop `docker ps -qa` > /dev/null 2>&1
+
+cd search


Similar question, why is this needed?

I have stated many times that search is just a folder name of the repo.
If you just git clone opensearch then the default folder is opensearch not search.
The reason we use search back in the day because opensearch naming is not defined.

If you clone as opensearch (which seems like you do in the jenkins file), you should remove cd into search and cd into the corresponding folder instead.

Sure that makes sense, the question was to @owaiskazi19, do we still need this ?

Changed the design. Created a new ubuntu docker image for gradle check purpose and run it in a jenkisnfile. We don't need the scripts anymore.

saratvemulapalli · 2022-02-18T20:38:55Z

jenkins/gradle-check-assemble.sh

+REPORTS_DIR=`find ./search -name reports`
+zip -9 -q -r gradle_check_${BUILD_NUMBER}_reports.zip ${REPORTS_DIR}
+ls | grep "gradle_check_${BUILD_NUMBER}"


Not a blocker for this PR, just a thought:
Looks like we can publish code coverage results from here.
cc: @tlfeng

peterzhuamazon

I see a lot of code directly copy paste from previous Jenkins without considering the circumstances of the new Jenkins and why the old code was being written that way.

I also would like to see some results of this workflow in practice before approving it.

Seems like the jenkins pipeline file is also written in scripted way instead of decalarative which makes the maintenance a bit harder.

Block this PR for now as I am concerned about the outcome of this PR.

jenkins/post-build-task2.sh

peterzhuamazon · 2022-02-22T19:49:12Z

Hi Owais,

Also realize this is not even a Jenkins Pipeline file, but instead a dsl groovy which we are not using anymore.

Please follow the build repo jenkins folder to see examples of how to setup proper jenkinsfile
The workflow needs to be run within a docker container. Since you are running multiple containers within the runner container, you need to use the ubuntu buildx image we provided for docker build, see jenkins/docker for instances.
You should simplify the workflow and remove old scripts from the old workflow if they can be re-written or replaced in the new setup.
You pipeline should be able to run on our dev jenkins and should be testable.

Thanks.

cc: @bbarani

Signed-off-by: Owais Kazi <[email protected]>

owaiskazi19 · 2022-03-25T18:11:16Z

Thanks for the input here @peterzhuamazon. I have pushed the changes.

opensearch-ci-bot · 2022-03-25T18:44:14Z

❌ Gradle Check failure 3031c13
Log 3761

Reports 3761

owaiskazi19 · 2022-03-25T18:53:07Z

#1703

owaiskazi19 · 2022-03-25T18:53:14Z

start gradle check

opensearch-ci-bot · 2022-03-25T19:32:49Z

✅ Gradle Check success 3031c13
Log 3765

Reports 3765

gaiksaya

Great to see such a short JenkinsFile :)

gaiksaya · 2022-03-25T22:01:15Z

jenkins/jenkinsfile

+    agent {
+         docker {
+            label 'AL2-X64'
+            image 'opensearchstaging/ci-runner:ci-runner-ubuntu1804-build-v1'


Maybe add link to this docker file: https://github.com/opensearch-project/opensearch-build/blob/main/docker/ci/dockerfiles/build.ubuntu18.opensearch.x64.dockerfile if anyone wants to see whats in the docker image

Sounds good. Pushed the change. Thanks for the review :)

Signed-off-by: Owais Kazi <[email protected]>

opensearch-ci-bot · 2022-03-25T22:52:20Z

✅ Gradle Check success 82f97b1
Log 3771

Reports 3771

abhinavGupta16 · 2022-03-28T17:09:07Z

jenkins/jenkinsfile

@@ -0,0 +1,32 @@
+pipeline {
+    agent {


@owaiskazi19 - Can you help create a test case for this job and add timeout as well? Thank you!

@abhinavGupta16 can you create an issue for the above so that it can be pick up later? Thanks

@owaiskazi19 - #2690 . There you go!

* Added jenkinsfile for gradle check Signed-off-by: Owais Kazi <[email protected]> * Added jenkinsfile to run gradle check Signed-off-by: Owais Kazi <[email protected]> * PR comment Signed-off-by: Owais Kazi <[email protected]> (cherry picked from commit f1d35d0)

* Added jenkinsfile for gradle check Signed-off-by: Owais Kazi <[email protected]> * Added jenkinsfile to run gradle check Signed-off-by: Owais Kazi <[email protected]> * PR comment Signed-off-by: Owais Kazi <[email protected]> (cherry picked from commit f1d35d0) Co-authored-by: Owais Kazi <[email protected]>

owaiskazi19 requested a review from a team as a code owner February 18, 2022 02:35

owaiskazi19 force-pushed the jenkins branch from b30ca61 to bce0434 Compare February 18, 2022 02:36

owaiskazi19 mentioned this pull request Feb 18, 2022

Moved Gradle check into OpenSearch repo #1665

Closed

5 tasks

owaiskazi19 changed the title ~~Moved Gradle check into OpenSearch repo~~ Moved Gradle check scripts into OpenSearch repo Feb 18, 2022

dblock approved these changes Feb 18, 2022

View reviewed changes

jenkins/gradle-check-assemble.sh Outdated Show resolved Hide resolved

jenkins/gradle-check-assemble.sh Outdated Show resolved Hide resolved

owaiskazi19 requested a review from peterzhuamazon February 18, 2022 17:46

setiah reviewed Feb 18, 2022

View reviewed changes

jenkins/gradle-check-assemble.sh Outdated Show resolved Hide resolved

setiah reviewed Feb 18, 2022

View reviewed changes

jenkins/post-build-task2.sh Outdated Show resolved Hide resolved

saratvemulapalli reviewed Feb 18, 2022

View reviewed changes

peterzhuamazon requested changes Feb 22, 2022

View reviewed changes

peterzhuamazon reviewed Feb 22, 2022

View reviewed changes

jenkins/post-build-task2.sh Outdated Show resolved Hide resolved

abhinavGupta16 mentioned this pull request Mar 7, 2022

Pickup Java version from .properties in OpenSearch gradle check #2395

Closed

owaiskazi19 added 2 commits March 25, 2022 17:49

Added jenkinsfile for gradle check

814245e

Signed-off-by: Owais Kazi <[email protected]>

Added jenkinsfile to run gradle check

3031c13

Signed-off-by: Owais Kazi <[email protected]>

owaiskazi19 force-pushed the jenkins branch from bce0434 to 3031c13 Compare March 25, 2022 18:08

owaiskazi19 requested a review from peterzhuamazon March 25, 2022 18:11

owaiskazi19 changed the title ~~Moved Gradle check scripts into OpenSearch repo~~ Added jenkinsfile to run gradle check in OpenSearch Mar 25, 2022

gaiksaya approved these changes Mar 25, 2022

View reviewed changes

PR comment

82f97b1

Signed-off-by: Owais Kazi <[email protected]>

CEHENKLE approved these changes Mar 25, 2022

View reviewed changes

CEHENKLE merged commit f1d35d0 into opensearch-project:main Mar 25, 2022

abhinavGupta16 reviewed Mar 28, 2022

View reviewed changes

owaiskazi19 added backport 2.x Backport to 2.x branch backport 2.0 Backport to 2.0 branch labels Mar 28, 2022

opensearch-trigger-bot bot mentioned this pull request Mar 28, 2022

[Backport 2.x] Added jenkinsfile to run gradle check in OpenSearch #2628

Merged

opensearch-trigger-bot bot mentioned this pull request Mar 28, 2022

[Backport 2.0] Added jenkinsfile to run gradle check in OpenSearch #2629

Merged

dblock mentioned this pull request Mar 29, 2022

Use JDK 11 or 17 for gradle check #2644

Closed

owaiskazi19 mentioned this pull request Mar 30, 2022

[Backport-1.x] Added jenkisfile to run gradle check in OpenSearch #2668

Merged

5 tasks

abhinavGupta16 mentioned this pull request Mar 31, 2022

Add timeout to gradle check jenkins job and test cases if possible #2690

Open

gaiksaya mentioned this pull request Apr 29, 2022

Gradle Check Jenkins DSL is not in this repository. opensearch-project/opensearch-ci#17

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added jenkinsfile to run gradle check in OpenSearch #2166

Added jenkinsfile to run gradle check in OpenSearch #2166

owaiskazi19 commented Feb 18, 2022 •

edited

Loading

opensearch-ci-bot commented Feb 18, 2022

opensearch-ci-bot commented Feb 18, 2022

opensearch-ci-bot commented Feb 18, 2022

saratvemulapalli Feb 18, 2022

peterzhuamazon Feb 22, 2022 •

edited

Loading

saratvemulapalli Feb 22, 2022

owaiskazi19 Mar 25, 2022

saratvemulapalli Feb 18, 2022

peterzhuamazon left a comment

peterzhuamazon commented Feb 22, 2022

owaiskazi19 commented Mar 25, 2022 •

edited

Loading

opensearch-ci-bot commented Mar 25, 2022

owaiskazi19 commented Mar 25, 2022

owaiskazi19 commented Mar 25, 2022

opensearch-ci-bot commented Mar 25, 2022

gaiksaya left a comment

gaiksaya Mar 25, 2022

owaiskazi19 Mar 25, 2022

opensearch-ci-bot commented Mar 25, 2022

abhinavGupta16 Mar 28, 2022

owaiskazi19 Mar 28, 2022

abhinavGupta16 Mar 31, 2022 •

edited

Loading

Added jenkinsfile to run gradle check in OpenSearch #2166

Added jenkinsfile to run gradle check in OpenSearch #2166

Conversation

owaiskazi19 commented Feb 18, 2022 • edited Loading

Description

Issues Resolved

Check List

opensearch-ci-bot commented Feb 18, 2022

opensearch-ci-bot commented Feb 18, 2022

opensearch-ci-bot commented Feb 18, 2022

Choose a reason for hiding this comment

peterzhuamazon Feb 22, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

peterzhuamazon left a comment

Choose a reason for hiding this comment

peterzhuamazon commented Feb 22, 2022

owaiskazi19 commented Mar 25, 2022 • edited Loading

opensearch-ci-bot commented Mar 25, 2022

owaiskazi19 commented Mar 25, 2022

owaiskazi19 commented Mar 25, 2022

opensearch-ci-bot commented Mar 25, 2022

gaiksaya left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

opensearch-ci-bot commented Mar 25, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

abhinavGupta16 Mar 31, 2022 • edited Loading

Choose a reason for hiding this comment

owaiskazi19 commented Feb 18, 2022 •

edited

Loading

peterzhuamazon Feb 22, 2022 •

edited

Loading

owaiskazi19 commented Mar 25, 2022 •

edited

Loading

abhinavGupta16 Mar 31, 2022 •

edited

Loading