Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pickup Java version from .properties in OpenSearch gradle check #2395

Closed
dblock opened this issue Nov 17, 2021 · 6 comments · Fixed by opensearch-project/opensearch-build#2462
Labels
Build Libraries & Interfaces enhancement Enhancement or improvement to existing feature or request

Comments

@dblock
Copy link
Member

dblock commented Nov 17, 2021

Is your feature request related to a problem? Please describe

Coming from opensearch-project/opensearch-build#74 (comment). Use different JDKs depending on which branch of OpenSearch is being built.

Describe the solution you'd like

OpenSearch has CI defined in a private freestyle project that runs gradle check on OpenSearch#main, branches and PRs. It will get extracted into a Jenkinsfile that is committed to the OpenSearch repo in opensearch-project/opensearch-build#851.

It will then needs to pickup the JDK version to use from https://github.com/opensearch-project/OpenSearch/blob/main/.ci/java-versions.properties#L16.

Describe alternatives you've considered

No response

Additional context

No response

@bbarani
Copy link
Member

bbarani commented Mar 7, 2022

Transferring this issue to https://github.com/opensearch-project/OpenSearch/ repo as this enhancement will be addressed as part of Gradle check migration process.

@bbarani bbarani transferred this issue from opensearch-project/opensearch-build Mar 7, 2022
@bbarani bbarani reopened this Mar 7, 2022
@dblock dblock added v2.0.0 Version 2.0.0 and removed v1.3.0 labels Mar 9, 2022
@anasalkouz anasalkouz added Build Libraries & Interfaces and removed v2.0.0 Version 2.0.0 labels Apr 12, 2022
@minalsha
Copy link
Contributor

minalsha commented Aug 2, 2022

@bbarani is this already addressed?

@dblock
Copy link
Member Author

dblock commented Aug 5, 2022

@peterzhuamazon would know - show us where we get the java version in gradle checks?

@peterzhuamazon
Copy link
Member

@peterzhuamazon would know - show us where we get the java version in gradle checks?

You can improve it by getting it from versions.properties, and sent from webhook to Jenkins runs.
https://github.com/opensearch-project/opensearch-build/blob/main/vars/runGradleCheck.groovy#L36-L42

@dblock
Copy link
Member Author

dblock commented Aug 11, 2022

Thanks @peterzhuamazon - @minalsha this is not done, care to queue it up?

@reta
Copy link
Collaborator

reta commented Aug 16, 2022

@peterzhuamazon @dblock since build infra is open now, I could take it (if there are no objections)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Libraries & Interfaces enhancement Enhancement or improvement to existing feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants