Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Gradle wrapper and precommit checks into OpenSearch repo. #1664

Merged
merged 3 commits into from
Dec 8, 2021
Merged

Move Gradle wrapper and precommit checks into OpenSearch repo. #1664

merged 3 commits into from
Dec 8, 2021

Conversation

dblock
Copy link
Member

@dblock dblock commented Dec 7, 2021

Signed-off-by: dblock [email protected]

Description

As part of #2395, move gradle wrapper and precommit checks into the OpenSearch GHA. These currently are implemented and running on a private Jenkins instance, which needs not to be.

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dblock dblock requested a review from a team as a code owner December 7, 2021 17:38
@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

saratvemulapalli
saratvemulapalli reviewed Dec 7, 2021
View reviewed changes
.github/workflows/wrapper.yml Outdated
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Check Gradle Wrapper
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gradle publishes an action for verifying jars via https://github.com/gradle/wrapper-validation-action, may be we should give it a shot.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

name: Validate Gradle Wrapper
on:
  pull_request:
    branches:
      - main

jobs:
  validation:
    name: Validation
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v2
      - uses: gradle/wrapper-validation-action@v1

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding this, updated!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

2s
Run gradle/wrapper-validation-action@v1
✓ Found known Gradle Wrapper JAR files:
  33ad4583fd7ee156f533778736fa1b4940bd83b433934d1cc4e9f608e99a6a89 gradle/wrapper/gradle-wrapper.jar

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@dblock dblock added backport 1.x pending backport Identifies an issue or PR that still needs to be backported labels Dec 7, 2021
saratvemulapalli
saratvemulapalli reviewed Dec 7, 2021
View reviewed changes
.github/workflows/wrapper.yml
jobs:
validate:
name: Validate
runs-on: ubuntu-latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we support windows builds on OpenSearch?
If so we should run these checks on multi platforms.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do other platforms separately.

@owaiskazi19
Copy link
Member

start gradle check

@saratvemulapalli
Copy link
Member

start gradle check

PR checks on Jenkins is out due to AWS Outage.

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Precommit failure 4a9d15c
Log 1715

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Precommit failure 4412234
Log 1716

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Precommit failure 9f55db6cfce92494169da0d5e477631390eeba3e
Log 1717

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Wrapper Validation failure 9f55db6cfce92494169da0d5e477631390eeba3e

:alert: Gradle Wrapper integrity has been altered

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Wrapper Validation failure 4412234

:alert: Gradle Wrapper integrity has been altered

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Wrapper Validation failure 4a9d15c

:alert: Gradle Wrapper integrity has been altered

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 4412234
Log 1360

Reports 1360

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 4a9d15c
Log 1359

Reports 1359

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 9f55db6cfce92494169da0d5e477631390eeba3e
Log 1361

Reports 1361

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success 068a540

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success 068a540

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 9f55db6cfce92494169da0d5e477631390eeba3e
Log 1367

Reports 1367

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 9f55db6cfce92494169da0d5e477631390eeba3e
Log 1366

Reports 1366

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 068a540
Log 1371

Reports 1371

@dblock
Copy link
Member Author

dblock commented Dec 8, 2021

start gradle check

@dblock dblock mentioned this pull request Dec 8, 2021
Merged
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 068a540
Log 1376

Reports 1376

@saratvemulapalli saratvemulapalli merged commit e983fac into opensearch-project:main Dec 8, 2021
dblock added a commit to dblock/OpenSearch that referenced this pull request Dec 8, 2021
@dblock
Move Gradle wrapper and precommit checks into OpenSearch repo. (opens…
2f77500 
…earch-project#1664)

* Move Gradle checks into OpenSearch repo.

Signed-off-by: dblock <[email protected]>

* Use working-directory for gradle wrapper validation.

Signed-off-by: dblock <[email protected]>

* Use https://github.com/gradle/wrapper-validation-action.

Signed-off-by: dblock <[email protected]>
@dblock dblock mentioned this pull request Dec 8, 2021
Merged
saratvemulapalli pushed a commit that referenced this pull request Dec 8, 2021
@dblock
Move Gradle wrapper and precommit checks into OpenSearch repo. (#1664) (
3e7f4ab 
#1678)

* Move Gradle checks into OpenSearch repo.

Signed-off-by: dblock <[email protected]>

* Use working-directory for gradle wrapper validation.

Signed-off-by: dblock <[email protected]>

* Use https://github.com/gradle/wrapper-validation-action.

Signed-off-by: dblock <[email protected]>
@dblock dblock deleted the gradle-checks branch December 8, 2021 18:13
dblock added a commit to dblock/OpenSearch that referenced this pull request Dec 10, 2021
@dblock
Move Gradle wrapper and precommit checks into OpenSearch repo. (opens…
d8bafa8 
…earch-project#1664)

* Move Gradle checks into OpenSearch repo.

Signed-off-by: dblock <[email protected]>

* Use working-directory for gradle wrapper validation.

Signed-off-by: dblock <[email protected]>

* Use https://github.com/gradle/wrapper-validation-action.

Signed-off-by: dblock <[email protected]>
@dblock dblock mentioned this pull request Dec 10, 2021
Merged
1 task
saratvemulapalli pushed a commit that referenced this pull request Dec 10, 2021
@dblock
Increment version to 1.2.1 (#1700)
db4df4b 
* Increment version to 1.2.1.

Signed-off-by: dblock <[email protected]>

* Move Gradle wrapper and precommit checks into OpenSearch repo. (#1664)

* Move Gradle checks into OpenSearch repo.

Signed-off-by: dblock <[email protected]>

* Use working-directory for gradle wrapper validation.

Signed-off-by: dblock <[email protected]>

* Use https://github.com/gradle/wrapper-validation-action.

Signed-off-by: dblock <[email protected]>

* Use Java 14.

Signed-off-by: dblock <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saratvemulapalli saratvemulapalli saratvemulapalli approved these changes

@reta reta reta approved these changes

@owaiskazi19 owaiskazi19 owaiskazi19 approved these changes

Assignees
No one assigned
Labels
backport 1.x pending backport Identifies an issue or PR that still needs to be backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dblock @opensearch-ci-bot @owaiskazi19 @saratvemulapalli @reta