-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validation while updating CompatibilityMode setting #13080
Add validation while updating CompatibilityMode setting #13080
Conversation
❌ Gradle check result for 8b05f9d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Compatibility status:Checks if related components are compatible with change 7b1cc3e Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/performance-analyzer.git] |
.../java/org/opensearch/action/admin/cluster/settings/TransportClusterUpdateSettingsAction.java
Outdated
Show resolved
Hide resolved
.../java/org/opensearch/action/admin/cluster/settings/TransportClusterUpdateSettingsAction.java
Outdated
Show resolved
Hide resolved
.../java/org/opensearch/action/admin/cluster/settings/TransportClusterUpdateSettingsAction.java
Outdated
Show resolved
Hide resolved
.../java/org/opensearch/action/admin/cluster/settings/TransportClusterUpdateSettingsAction.java
Outdated
Show resolved
Hide resolved
.../java/org/opensearch/action/admin/cluster/settings/TransportClusterUpdateSettingsAction.java
Outdated
Show resolved
Hide resolved
❌ Gradle check result for 54ab728: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
54ab728
to
6d434aa
Compare
❌ Gradle check result for 6d434aa: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
6d434aa
to
7237a5f
Compare
❕ Gradle check result for 7237a5f: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13080 +/- ##
============================================
+ Coverage 71.42% 71.47% +0.05%
- Complexity 59978 60547 +569
============================================
Files 4985 5033 +48
Lines 282275 285009 +2734
Branches 40946 41306 +360
============================================
+ Hits 201603 203699 +2096
- Misses 63999 64442 +443
- Partials 16673 16868 +195 ☔ View full report in Codecov by Sentry. |
server/src/main/java/org/opensearch/cluster/metadata/MetadataCreateIndexService.java
Outdated
Show resolved
Hide resolved
.../java/org/opensearch/action/admin/cluster/settings/TransportClusterUpdateSettingsAction.java
Outdated
Show resolved
Hide resolved
...nalClusterTest/java/org/opensearch/remotemigration/RemoteStoreMigrationSettingsUpdateIT.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Lakshya Taragi <[email protected]>
Signed-off-by: Lakshya Taragi <[email protected]>
2c938a8
to
1525c9b
Compare
❌ Gradle check result for 1525c9b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Lakshya Taragi <[email protected]>
1525c9b
to
7b1cc3e
Compare
❕ Gradle check result for 2c938a8: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
❕ Gradle check result for 7b1cc3e: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Flaky test #8928
Flaky test #10006 |
...nalClusterTest/java/org/opensearch/remotemigration/RemoteStoreMigrationSettingsUpdateIT.java
Show resolved
Hide resolved
Overall LGTM. Please add the IT for min/max version check |
Signed-off-by: Lakshya Taragi <[email protected]> (cherry picked from commit 695fbde) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
) (cherry picked from commit 695fbde) Signed-off-by: Lakshya Taragi <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
This PR implements the following two checks while updating the
CompatibilityMode
setting:STRICT
<-->MIXED
) theCompatibilityMode
if all the nodes in the cluster are not of the same open search versionSTRICT
mode if the cluster contains both remote and non-remote nodesThis was done as follows:
TransportClusterUpdateSettingsAction
receives both theClusterUpdateSettingsRequest
andClusterState
CompatibilityMode
can be found inside theClusterUpdateSettingsRequest
objectClusterState
objectvalidateCompatibilityModeSettingRequest
ensures the required checks by in turn callingvalidateAllNodesOfSameVersion
andvalidateAllNodesOfSameType
Related Issues
Check List
Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)Commit changes are listed out in CHANGELOG.md file (See: Changelog)Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.