Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remote Store] Validation while updating CompatibilityMode setting #13078

Closed
ltaragi opened this issue Apr 4, 2024 · 0 comments · Fixed by #13080
Closed

[Remote Store] Validation while updating CompatibilityMode setting #13078

ltaragi opened this issue Apr 4, 2024 · 0 comments · Fixed by #13080
Assignees
Labels
enhancement Enhancement or improvement to existing feature or request Storage:Durability Issues and PRs related to the durability framework Storage:Remote

Comments

@ltaragi
Copy link
Contributor

ltaragi commented Apr 4, 2024

Is your feature request related to a problem? Please describe

The following two checks should be implemented while updating the CompatibilityMode setting:

  • Don't allow changing the CompatibilityMode (STRICT <--> MIXED) if all the nodes in the cluster are not of the same open search version
  • Don't allow switching to STRICT mode if the cluster contains both remote and non-remote nodes

Describe the solution you'd like

This can be accomplished as follows:

  • TransportClusterUpdateSettingsAction receives both the ClusterUpdateSettingsRequest and ClusterState objects
  • The requested new value for CompatibilityMode can be found inside the ClusterUpdateSettingsRequest object
  • Information on nodes like remote store enabled nature and opensearch version can be found inside the ClusterState object
  • The above checks can be implemented with this available information

Related component

Storage:Remote

Describe alternatives you've considered

No response

Additional context

No response

@ltaragi ltaragi added enhancement Enhancement or improvement to existing feature or request Storage:Durability Issues and PRs related to the durability framework Storage:Remote labels Apr 4, 2024
@ltaragi ltaragi self-assigned this Apr 4, 2024
@ltaragi ltaragi removed the untriaged label Apr 4, 2024
@ltaragi ltaragi moved this from 🆕 New to 👀 In review in Storage Project Board Apr 4, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Storage Project Board Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request Storage:Durability Issues and PRs related to the durability framework Storage:Remote
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

1 participant