[Backport 2.13] Added static setting for checkPendingFlushUpdate functionality of lucene index writer

[CaptainDredge]

Description

Backports PR #12786 to 2.13

Related Issues

Resolves #11628

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)
• Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[reta]

@CaptainDredge do we have a sign-off from @bbarani @gaiksaya to bring this one to 2.13? (the release is cut already)

[CaptainDredge]

@reta I don't have sign-off yet but I'm wondering why this didn't get to 2.13 in the first place automatically when it was merged in 2.x 2 days back i.e. much before RC release 😕

[reta]

@reta I don't have sign-off yet but I'm wondering why this didn't get to 2.13 in the first place automatically when it was merged in 2.x 2 days back i.e. much before RC release 😕

We are where we are :(, please ask for sign off

[reta]

Blocking the merge till we get 2.13 clearance

[github-actions]

Compatibility status:

Checks if related components are compatible with change ae3c9b1

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/performance-analyzer.git]

[github-actions]

✅ Gradle check result for be51b99: SUCCESS

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (2.13@db00468). Click here to learn what that means.

Additional details and impacted files

@@           Coverage Diff           @@
##             2.13   #12857   +/-   ##
=======================================
  Coverage        ?   71.09%           
  Complexity      ?    60288           
=======================================
  Files           ?     4984           
  Lines           ?   284232           
  Branches        ?    41540           
=======================================
  Hits            ?   202069           
  Misses          ?    65087           
  Partials        ?    17076           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[gaiksaya]

@CaptainDredge do we have a sign-off from @bbarani @gaiksaya to bring this one to 2.13? (the release is cut already)

Please go ahead.

[gaiksaya]

@reta I don't have sign-off yet but I'm wondering why this didn't get to 2.13 in the first place automatically when it was merged in 2.x 2 days back i.e. much before RC release 😕

2.13 was cut 3 days back honoring code cut off date. Anything merged after that needs to go in 2.13 as well.

[bbarani]

Blocking the merge till we get 2.13 clearance

Thanks @reta for surfacing this issue to release team. @CaptainDredge Can you check and let us know why we missed this backport? Do we need to add any additional guard rails? We need to make sure this doesn't happen again for anyone.

[CaptainDredge]

@reta / @shwetathareja can you please merge the PR now since we have the signoff?

[github-actions]

❌ Gradle check result for 4ceb77c:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❕ Gradle check result for ae3c9b1: UNSTABLE

• TEST FAILURES:

      1 org.opensearch.cluster.allocation.ClusterRerouteIT.testDelayWithALargeAmountOfShards
      1 org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=indices.get_field_mapping/20_missing_field/Return empty object if field doesn't exist, but index does}

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.