-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added static setting for checkPendingFlushUpdate functionality of lucene index writer #12710
Conversation
Compatibility status:Checks if related components are compatible with change b9593db Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/sql.git] |
6f7b98c
to
24cf9eb
Compare
❌ Gradle check result for 8d17786: ABORTED Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
8d17786
to
36a7c7e
Compare
…ene writer Signed-off-by: Prabhat Sharma <[email protected]>
36a7c7e
to
b9593db
Compare
❌ Gradle check result for 36a7c7e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❕ Gradle check result for b9593db: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Flaky tests failing |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-12710-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c369ec44e381ddb85db647d89389842952a1c06a
# Push it to GitHub
git push --set-upstream origin backport/backport-12710-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
@CaptainDredge could you please backport to |
sure @reta |
…ene writer (opensearch-project#12710) Signed-off-by: Prabhat Sharma <[email protected]> Co-authored-by: Prabhat Sharma <[email protected]> (cherry picked from commit c369ec4)
…ene writer (opensearch-project#12710) Signed-off-by: Prabhat Sharma <[email protected]> Co-authored-by: Prabhat Sharma <[email protected]> (cherry picked from commit c369ec4)
@CaptainDredge please don't forget to update documentation [1] with this new setting, thank you [1] https://github.com/opensearch-project/documentation-website/issues |
Thanks @reta Already the PR for documentation is open. I'm hoping a doc writer in US timing will merge it |
…ene writer (#12710) (#12786) Signed-off-by: Prabhat Sharma <[email protected]> Co-authored-by: Prabhat Sharma <[email protected]> (cherry picked from commit c369ec4)
…ene writer (opensearch-project#12710) (opensearch-project#12786) Signed-off-by: Prabhat Sharma <[email protected]> Co-authored-by: Prabhat Sharma <[email protected]> (cherry picked from commit c369ec4) (cherry picked from commit 29bcc48)
…ene writer (opensearch-project#12710) (opensearch-project#12786) Signed-off-by: Prabhat Sharma <[email protected]> Co-authored-by: Prabhat Sharma <[email protected]> (cherry picked from commit c369ec4) (cherry picked from commit 29bcc48) Signed-off-by: Prabhat Sharma <[email protected]>
…ene writer (opensearch-project#12710) (opensearch-project#12786) Signed-off-by: Prabhat Sharma <[email protected]> Co-authored-by: Prabhat Sharma <[email protected]> (cherry picked from commit c369ec4) (cherry picked from commit 29bcc48) Signed-off-by: Prabhat Sharma <[email protected]>
…ene writer (#12710) (#12786) (#12857) (cherry picked from commit c369ec4) (cherry picked from commit 29bcc48) Signed-off-by: Prabhat Sharma <[email protected]> Co-authored-by: Prabhat Sharma <[email protected]>
…ene writer (opensearch-project#12710) Signed-off-by: Prabhat Sharma <[email protected]> Co-authored-by: Prabhat Sharma <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
This PR exposes the setting
index.check_pending_flush.enabled
setting to control lucene index writer checkPendingFlushOnUpdateRelated Issues
Resolves #11628
Check List
New functionality includes testing.All tests passBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.