Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support hashtag in token filter type_table rules parser #10220

Merged

Conversation

noCharger
Copy link
Contributor

@noCharger noCharger commented Sep 25, 2023

Description

Support hashtag in token filter type_table rules parser

Related Issues

Resolves #6867

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added bug Something isn't working Search Search query, autocomplete ...etc Search:Query Capabilities labels Sep 25, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2023

Compatibility status:

Checks if related components are compatible with change a85be4d

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #10220 (a85be4d) into main (a8969cb) will decrease coverage by 0.06%.
Report is 2 commits behind head on main.
The diff coverage is 84.07%.

@@             Coverage Diff              @@
##               main   #10220      +/-   ##
============================================
- Coverage     71.11%   71.05%   -0.06%     
+ Complexity    58188    58172      -16     
============================================
  Files          4830     4830              
  Lines        274440   274505      +65     
  Branches      39993    40002       +9     
============================================
- Hits         195175   195061     -114     
- Misses        62897    63058     +161     
- Partials      16368    16386      +18     
Files Coverage Δ
...src/main/java/org/opensearch/core/index/Index.java 100.00% <ø> (ø)
...arch/analysis/common/MappingCharFilterFactory.java 50.00% <100.00%> (ø)
...luster/metadata/MetadataUpdateSettingsService.java 70.37% <100.00%> (-0.38%) ⬇️
...rg/opensearch/common/settings/ClusterSettings.java 92.85% <ø> (ø)
...n/java/org/opensearch/index/analysis/Analysis.java 84.21% <100.00%> (-0.12%) ⬇️
...rch/index/remote/RemoteSegmentTransferTracker.java 81.10% <100.00%> (+0.17%) ⬆️
...index/shard/CloseableRetryableRefreshListener.java 81.03% <100.00%> (+0.67%) ⬆️
...in/java/org/opensearch/index/shard/IndexShard.java 69.50% <100.00%> (+0.63%) ⬆️
...java/org/opensearch/index/shard/StoreRecovery.java 56.43% <ø> (-0.38%) ⬇️
...earch/index/store/RemoteSegmentStoreDirectory.java 89.67% <100.00%> (+0.26%) ⬆️
... and 15 more

... and 459 files with indirect coverage changes

@noCharger noCharger force-pushed the feature-hashtag-token-filter-parser branch from 46c6db3 to a85be4d Compare September 26, 2023 18:50
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.search.pit.DeletePitMultiNodeIT.testDeleteWhileSearch
      1 org.opensearch.indices.replication.SegmentReplicationIT.classMethod

@noCharger noCharger requested a review from reta September 26, 2023 19:49
@reta
Copy link
Collaborator

reta commented Sep 27, 2023

@msfroh mind taking a look please ? thank you!

@msfroh msfroh merged commit 8f4f995 into opensearch-project:main Sep 27, 2023
17 checks passed
@noCharger noCharger added the backport 2.x Backport to 2.x branch label Sep 27, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 27, 2023
…0220)

* Support hashtag in token filter type_table rules parser

Signed-off-by: Louis Chu <[email protected]>

* Address comment from @reta

Signed-off-by: Louis Chu <[email protected]>

---------

Signed-off-by: Louis Chu <[email protected]>
(cherry picked from commit 8f4f995)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta pushed a commit that referenced this pull request Sep 28, 2023
…0220) (#10257)

* Support hashtag in token filter type_table rules parser



* Address comment from @reta



---------


(cherry picked from commit 8f4f995)

Signed-off-by: Louis Chu <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@noCharger noCharger added the v2.11.0 Issues and PRs related to version 2.11.0 label Oct 4, 2023
deshsidd pushed a commit to deshsidd/OpenSearch that referenced this pull request Oct 9, 2023
…ensearch-project#10220)

* Support hashtag in token filter type_table rules parser

Signed-off-by: Louis Chu <[email protected]>

* Address comment from @reta

Signed-off-by: Louis Chu <[email protected]>

---------

Signed-off-by: Louis Chu <[email protected]>
vikasvb90 pushed a commit to vikasvb90/OpenSearch that referenced this pull request Oct 10, 2023
…ensearch-project#10220)

* Support hashtag in token filter type_table rules parser

Signed-off-by: Louis Chu <[email protected]>

* Address comment from @reta

Signed-off-by: Louis Chu <[email protected]>

---------

Signed-off-by: Louis Chu <[email protected]>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…ensearch-project#10220)

* Support hashtag in token filter type_table rules parser

Signed-off-by: Louis Chu <[email protected]>

* Address comment from @reta

Signed-off-by: Louis Chu <[email protected]>

---------

Signed-off-by: Louis Chu <[email protected]>
Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch bug Something isn't working Search:Query Capabilities Search Search query, autocomplete ...etc skip-changelog v2.11.0 Issues and PRs related to version 2.11.0
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG] "# => ALPHANUM" in word_delimiter filter's type_table can cause exception.
3 participants