Address comment from @reta

Signed-off-by: Louis Chu <[email protected]>
opensearch-project · Sep 26, 2023 · a85be4d · a85be4d
1 parent e7344ab
commit a85be4d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/...common/src/yamlRestTest/resources/rest-api-spec/test/analysis-common/40_token_filters.yml b/...common/src/yamlRestTest/resources/rest-api-spec/test/analysis-common/40_token_filters.yml
@@ -156,6 +156,7 @@
               - type: word_delimiter
                 split_on_numerics: false
                 type_table:
+                  - "# This is a comment"
                   - "# => ALPHANUM"
     - length: { tokens: 2 }
     - match: { tokens.0.token: text1 }
@@ -176,6 +177,7 @@
               - type: word_delimiter
                 split_on_numerics: false
                 type_table:
+                  - "# This is a comment"
                   - "# => ALPHANUM"
                   - "@ => ALPHANUM"
     - length: { tokens: 2 }
@@ -321,6 +323,7 @@
               - type: word_delimiter_graph
                 split_on_numerics: false
                 type_table:
+                  - "# This is a comment"
                   - "# => ALPHANUM"
     - length: { tokens: 2 }
     - match: { tokens.0.token: text1 }
@@ -341,6 +344,7 @@
               - type: word_delimiter_graph
                 split_on_numerics: false
                 type_table:
+                  - "# This is a comment"
                   - "# => ALPHANUM"
                   - "@ => ALPHANUM"
     - length: { tokens: 2 }

diff --git a/server/src/main/java/org/opensearch/index/analysis/Analysis.java b/server/src/main/java/org/opensearch/index/analysis/Analysis.java
@@ -100,7 +100,7 @@ public class Analysis {
     private static final Logger LOGGER = LogManager.getLogger(Analysis.class);
 
     // Regular expression to support hashtag tokenization
-    private static Pattern hashTagRulePattern = Pattern.compile("^\\s*#\\s*=>");
+    private static final Pattern HASH_TAG_RULE_PATTERN = Pattern.compile("^\\s*#\\s*=>");
 
     public static CharArraySet parseStemExclusion(Settings settings, CharArraySet defaultStemExclusion) {
         String value = settings.get("stem_exclusion");
@@ -249,7 +249,7 @@ public static <T> List<T> parseWordList(
         int lineNum = 0;
         for (String word : words) {
             lineNum++;
-            if (word.startsWith("#") == false || hashTagRulePattern.matcher(word).find()) {
+            if (word.startsWith("#") == false || HASH_TAG_RULE_PATTERN.matcher(word).find() == true) {
                 try {
                     rules.add(parser.apply(word));
                 } catch (RuntimeException ex) {