Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dynamic uses of i18n in core #8392

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

AMoo-Miki
Copy link
Collaborator

Description

Fix dynamic uses of i18n in core

Changelog

  • fix: Fix dynamic uses of i18n in core

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.92%. Comparing base (a663a84) to head (0c8f5f2).
Report is 25 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8392   +/-   ##
=======================================
  Coverage   60.92%   60.92%           
=======================================
  Files        3750     3750           
  Lines       89103    89103           
  Branches    13925    13925           
=======================================
  Hits        54285    54285           
  Misses      31442    31442           
  Partials     3376     3376           
Flag Coverage Δ
Linux_1 28.83% <ø> (ø)
Linux_2 56.35% <ø> (ø)
Linux_3 37.72% <ø> (ø)
Linux_4 29.96% <ø> (ø)
Windows_1 28.84% <ø> (ø)
Windows_2 56.30% <ø> (ø)
Windows_3 37.72% <ø> (ø)
Windows_4 29.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ashwin-pc ashwin-pc added the i18n Internationalization related Issues and PRs label Oct 1, 2024
@AMoo-Miki AMoo-Miki merged commit 8ff905f into opensearch-project:main Oct 2, 2024
73 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 2, 2024
* Fix dynamic uses of i18n in core

Signed-off-by: Miki <[email protected]>

* Changeset file for PR #8392 created/updated

---------

Signed-off-by: Miki <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 8ff905f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AMoo-Miki pushed a commit that referenced this pull request Oct 3, 2024
* Fix dynamic uses of i18n in core



* Changeset file for PR #8392 created/updated

---------



(cherry picked from commit 8ff905f)

Signed-off-by: Miki <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x distinguished-contributor i18n Internationalization related Issues and PRs v2.18.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants