Fix dynamic uses of i18n in core (#8392)

* Fix dynamic uses of i18n in core Signed-off-by: Miki <[email protected]> * Changeset file for PR #8392 created/updated --------- Signed-off-by: Miki <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
opensearch-project · Oct 2, 2024 · 8ff905f · 8ff905f
1 parent 1f9da21
commit 8ff905f
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/changelogs/fragments/8392.yml b/changelogs/fragments/8392.yml
@@ -0,0 +1,2 @@
+fix:
+- Fix dynamic uses of i18n in core ([#8392](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/8392))
diff --git a/src/core/public/i18n/i18n_eui_mapping.tsx b/src/core/public/i18n/i18n_eui_mapping.tsx
@@ -315,7 +315,7 @@ export const getEuiContextMapping = () => {
     ),
     'euiFilterButton.filterBadge': ({ count, hasActiveFilters }: EuiValues) =>
       i18n.translate('core.euiFilterButton.filterBadge', {
-        defaultMessage: '${count} ${filterCountLabel} filters',
+        defaultMessage: '{count} {filterCountLabel} filters',
         values: { count, filterCountLabel: hasActiveFilters ? 'active' : 'available' },
       }),
     'euiForm.addressFormErrors': i18n.translate('core.euiForm.addressFormErrors', {

diff --git a/src/core/server/rendering/views/template.tsx b/src/core/server/rendering/views/template.tsx
@@ -170,11 +170,14 @@ export const Template: FunctionComponent<Props> = ({
             <div
               className="osdWelcomeText"
               data-error-message={i18n('core.ui.welcomeErrorMessage', {
-                defaultMessage: `${applicationTitle} did not load properly. Check the server output for more information.`,
+                defaultMessage:
+                  '{applicationTitle} did not load properly. Check the server output for more information.',
+                values: { applicationTitle },
               })}
             >
               {i18n('core.ui.welcomeMessage', {
-                defaultMessage: `Loading ${applicationTitle}`,
+                defaultMessage: 'Loading {applicationTitle}',
+                values: { applicationTitle },
               })}
             </div>
             {/* Show a progress bar if a static custom branded logo is used */}
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		fix:
		- Fix dynamic uses of i18n in core ([#8392](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/8392))